Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release FX Devices v1.0beta9.6.6 #1217

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

BryanChi
Copy link
Contributor

-add more shortcut key options
-Fix 'When keys without modifiers have actions assigned to them, keys with modifires do not work. (e.g. If both Q and Shift + Q key have each action assigned to each of them, Q key action is triggered although I press Shift + Q key.)'

-add more shortcut key options
-Fix 'When keys without modifiers have actions assigned to them, keys with modifires do not work. (e.g. If both Q and Shift + Q key have each action assigned to each of them, Q key action is triggered although I press Shift + Q key.)'
@cfillion
Copy link
Member

cfillion commented Jul 20, 2023

Are the Msg calls at line 799 and 824 leftovers?

Also could do this to obtain an array of all keys in one go:

local AllAvailableKeys = {}
for name, func in pairs(reaper) do
  name = name:match('^ImGui_Key_(.+)')
  if name then AllAvailableKeys[name] = func() end
end

@BryanChi
Copy link
Contributor Author

oh yes the msg calls are unintentional, sorry I thought I checked!

Thanks! I remember there was something like this in the theme editor but don't remember how it was written. Oh well, I think I'll leave it as it is for now since there are some keys I want to exclude.

@cfillion cfillion merged commit 48dc2fa into ReaTeam:master Jul 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants