Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Linear TS search job adapter #695

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Added a Linear TS search job adapter #695

wants to merge 19 commits into from

Conversation

alongd
Copy link
Member

@alongd alongd commented Aug 21, 2023

Added a method for generating TS structures from atom mapped reactants and products.
The method works for unimolecular reactions, and at present is only implemented for isomerization reactions.

arc/job/adapters/ts/linear.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear_test.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear_test.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear_test.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear_test.py Fixed Show fixed Hide fixed
arc/job/adapters/ts/linear_test.py Fixed Show fixed Hide fixed
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Attention: Patch coverage is 87.93103% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 73.97%. Comparing base (3631196) to head (cbec920).

Current head cbec920 differs from pull request most recent head 69759f8

Please upload reports for the commit 69759f8 to get more accurate results.

Files Patch % Lines
arc/job/adapters/ts/linear.py 75.63% 18 Missing and 11 partials ⚠️
arc/mapping/engine.py 86.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   73.80%   73.97%   +0.17%     
==========================================
  Files          99      101       +2     
  Lines       27352    27596     +244     
  Branches     5718     5746      +28     
==========================================
+ Hits        20187    20415     +228     
- Misses       5738     5745       +7     
- Partials     1427     1436       +9     
Flag Coverage Δ
unittests 73.97% <87.93%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

arc/species/species.py Fixed Show fixed Hide fixed
arc/rmgdb.py Fixed Show fixed Hide fixed
@alongd alongd force-pushed the linear_ts branch 4 times, most recently from e22d3b6 to 8825e9f Compare May 15, 2024 06:10
@alongd alongd marked this pull request as ready for review May 15, 2024 09:26
from arc.plotter import save_geo
from arc.species.converter import order_xyz_by_atom_map, zmat_to_xyz
from arc.species.species import ARCSpecies, TSGuess, colliding_atoms
from arc.species.zmat import check_ordered_zmats, get_atom_order, update_zmat_by_xyz, xyz_to_zmat

Check notice

Code scanning / CodeQL

Unused import Note

Import of 'get_atom_order' is not used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant