Don't report convergence for IRC species #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #705 +/- ##
=======================================
Coverage 73.29% 73.29%
=======================================
Files 99 99
Lines 26557 26558 +1
Branches 5537 5538 +1
=======================================
+ Hits 19464 19466 +2
Misses 5745 5745
+ Partials 1348 1347 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
They were spawned by ARC to check a TS. They always "fail" in the classic meaning, since we don't attempt to compute freq/sp for them. It confuses the user to see failed species in an otherwise successful run
NellyMitnik
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were spawned by ARC to check a TS. They always "fail" in the classic meaning, since we don't attempt to compute freq/sp for them. It confuses the user to see failed species in an otherwise successful run