Sella env fix #711
Merged
Sella env fix #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinp0
force-pushed
the
sella_env_fix
branch
from
421274d to
014f2ed
Compare
calvinp0
force-pushed
the
sella_env_fix
branch
2 times, most recently
from
18ff541 to
7809706
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 73.53% 73.54%
=======================================
Files 99 99
Lines 26620 26620
Branches 5545 5545
=======================================
+ Hits 19576 19578 +2
+ Misses 5673 5672 -1
+ Partials 1371 1370 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alongd
approved these changes
Nov 14, 2023
Updated the bash script
Added python version - now 3.8 minimum added typing extensions as a packaged
calvinp0
force-pushed
the
sella_env_fix
branch
from
57032f3 to
d9c2e65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sella environment had issues installing due to the restriction of python being 3.7 which in turn cause supporting packages required for Sella not be installed. This then created issues for our testing