Skip to content

Removing file 1 and file 2 from Molpro's input file #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

MichalKesl
Copy link
Contributor

@MichalKesl MichalKesl commented Dec 10, 2023

Removing tow lines from Molpro's input file to write file 1 and file 2 due to an error that I'm encountering while running ARC or executing the Molpro job. Changed the tests accordingly.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70fe03c) 73.71% compared to head (23461db) 73.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #720   +/-   ##
=======================================
  Coverage   73.71%   73.71%           
=======================================
  Files          99       99           
  Lines       26992    26992           
  Branches     5620     5620           
=======================================
+ Hits        19896    19898    +2     
+ Misses       5698     5697    -1     
+ Partials     1398     1397    -1     
Flag Coverage Δ
unittests 73.71% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alongd
Copy link
Member

alongd commented Dec 16, 2023

@MichalKesl, what's the status of this branch? Can you rebase?

@calvinp0 calvinp0 merged commit 3b46df6 into main Dec 17, 2023
@calvinp0 calvinp0 deleted the molpro_comments branch December 17, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants