trsh logic change in run_job func call #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongd
reviewed
Dec 13, 2023
arc/scheduler.py
Outdated
| @@ -1012,7 +1012,7 @@ def _run_a_job(self, | |||
| max_job_time=job.max_job_time, | |||
| rotor_index=job.rotor_index, | |||
| reactions=job.reactions, | |||
| trsh=list(job.args['trsh'].values()) if 'trsh' in job.args else '', | |||
| trsh=job.args['trsh'] if 'trsh' in job.args and 'trsh' else [], | |||
There was a problem hiding this comment.
Take a look at and 'trsh', looks like it'll always evaluate to True
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 99 99
Lines 26992 26992
Branches 5620 5620
=======================================
+ Hits 19896 19898 +2
+ Misses 5698 5697 -1
+ Partials 1398 1397 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
this is to ensure that the dictionary in args['trsh'] is passed through the function correctly and to stop ['', '', 'nosymm'] syntax error . .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to ensure that the dictionary in args['trsh'] is passed through the function correctly and to stop ['', '', 'nosymm'] syntax error