Special chars creating submit issues #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue was stemming from local.py, the var called cmd
cmd = f'cd {path}; {submit_cmd} {submit_filename}'
here we defined path but never put it in quotations so special chars like `[` and `]` would be misinterpreted by the shell
so in python would change to the direct of /rxn_120_CCN/ instead of /rxn_120_[CH2]CN/ (assuming out intention was to go to /rxn_120_[CH2]CN/)
so just needed to change it to
cmd = f'cd "{path}"; {submit_cmd} {submit_filename}'
calvinp0
requested review from
alongd,
JintaoWu98,
Lilachn91,
MichalKesl and
NellyMitnik
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
=======================================
Coverage 73.71% 73.71%
=======================================
Files 99 99
Lines 26992 26992
Branches 5620 5620
=======================================
+ Hits 19896 19898 +2
+ Misses 5698 5697 -1
+ Partials 1398 1397 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue was stemming from local.py, the var called cmd
cmd = f'cd {path}; {submit_cmd} {submit_filename}'
here we defined path but never put it in quotations so special chars like
[and]would be misinterpreted by the shellso in python would change to the direct of /rxn_120_CCN/ instead of /rxn_120_[CH2]CN/ (assuming out intention was to go to /rxn_120_[CH2]CN/)
so just needed to change it to
cmd = f'cd "{path}"; {submit_cmd} {submit_filename}'