Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O2 perception #756

Merged
merged 3 commits into from
Jul 9, 2024
Merged

O2 perception #756

merged 3 commits into from
Jul 9, 2024

Conversation

alongd
Copy link
Member

@alongd alongd commented Jul 8, 2024

Fixes an issue with perceiving O2 as a triplet from xyz
test added

arc/species/converter.py Fixed Show fixed Hide fixed
alongd added 2 commits July 8, 2024 12:12
Fixes an issue with perceiving O2 as a triplet from xyz
N -0.96878800 0.63275900 0.00000000
N 1.01229100 0.58298500 0.00000000"""

xyz10 = """O -0.79494500 -0.93969200 0.00000000

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable xyz10 is not used.
N 0.14143500 0.11571500 0.00000000
H -1.65602000 -0.48026800 0.00000000"""

xyz11 = """O 1.64973000 -0.57433600 0.02610800

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable xyz11 is not used.
# H 1.76422500 -0.11051900 0.89038300
# H 1.40045900 1.41618100 0.00000000
# H -1.88127600 0.47189500 0.00000000"""
xyz13 = """O -0.37723000 -1.27051900 0.00000000

Check notice

Code scanning / CodeQL

Unused local variable Note

Variable xyz13 is not used.
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.70%. Comparing base (8b3b841) to head (b9b3304).

Files Patch % Lines
arc/species/converter.py 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   73.66%   73.70%   +0.03%     
==========================================
  Files          99       99              
  Lines       27418    27432      +14     
  Branches     5771     5773       +2     
==========================================
+ Hits        20198    20219      +21     
+ Misses       5770     5764       -6     
+ Partials     1450     1449       -1     
Flag Coverage Δ
unittests 73.70% <92.85%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@calvinp0 calvinp0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinp0 calvinp0 merged commit 0d16383 into main Jul 9, 2024
7 checks passed
@calvinp0 calvinp0 deleted the o2_perception branch July 9, 2024 08:09
alongd added a commit that referenced this pull request Jul 29, 2024
alongd added a commit that referenced this pull request Nov 6, 2024
alongd added a commit that referenced this pull request Dec 7, 2024
alongd added a commit that referenced this pull request Dec 7, 2024
@alongd alongd mentioned this pull request Dec 7, 2024
alongd added a commit that referenced this pull request Dec 8, 2024
Fixes an issue with perceiving S2 as a triplet from xyz, building upon #756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants