-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying species concentration range #48
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 73.95% 73.91% -0.05%
==========================================
Files 9 9
Lines 1478 1491 +13
Branches 378 381 +3
==========================================
+ Hits 1093 1102 +9
- Misses 253 255 +2
- Partials 132 134 +2
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging f340b5a into 652029d - view on LGTM.com new alerts:
|
874e292
to
4d6555c
Compare
RMG doesn't run as expected with ranged reactors when using a liquidReactor. |
This pull request introduces 1 alert when merging 4d6555c into 652029d - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 74.61% 74.03% -0.59%
==========================================
Files 9 9
Lines 1501 1521 +20
Branches 385 391 +6
==========================================
+ Hits 1120 1126 +6
- Misses 242 255 +13
- Partials 139 140 +1
Continue to review full report at Codecov.
|
2a9e663
to
2e2bae3
Compare
when it's 'converged' value is non-determined (i.e., if it's None)
So it's easier to track the calculation folder of species
Added an option to specify a concentration range to a species.
fixes #33