Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android-desktop target option #314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexvanyo
Copy link
Contributor

Adds android-desktop target option to fix #313

@ychescale9
Copy link
Member

Thanks! Do you mind adding android-desktop target to one of the jobs in the main.yml workflow so we can see how well it runs on GA? If it works well let's also update README.md and action.yml to include the new target:)

@alexvanyo alexvanyo force-pushed the patch-1 branch 3 times, most recently from d119ef4 to b306512 Compare February 9, 2023 01:48
@alexvanyo
Copy link
Contributor Author

After a few attempts, added tests and a new workflow action for the device.

The workflow appears to be failing on the creation step with "Error: No device found matching --device desktop_medium.", which is a bit strange since the same command works for me locally:

~/Android/Sdk/cmdline-tools/latest/bin/avdmanager create avd --force -n test --abi 'android-desktop/x86_64' --package 'system-images;android-32;android-desktop;x86_64' --device 'desktop_medium' --sdcard '100M'

Not sure if that seems familiar?

@ychescale9
Copy link
Member

It usually happens when the latest emulator binary or the system image for a newer API level is buggy / unstable.

I'll find some time to take a closer look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to specify desktop emulator
2 participants