Avoid sudo chown -R on ${ANDROID_HOME} on Linux
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
force-pushed
the
avoid-sudo-chown-on-Linux
branch
from
d597ec0
to
fda9df2
Compare
This seems to take several minutes, a decent fraction of the overall time in my
simple use.
Instead of changing the ownership of `${ANDROID_HOME}` instead arrange to run
individual commands under `sudo` when needed.
Note that `$PATH` is not preserved by `sudo` so we must use the full path to
the `sdkmanager`.
Another wrinkle is the cmdline-tools installation, since `tc.extractZip` and
`io.mv` do not include sudo-ish functionality. Instead precreate the target
directory with the ownership to allow the unpack as the current user.
ijc
force-pushed
the
avoid-sudo-chown-on-Linux
branch
from
fda9df2
to
e994454
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to take several minutes, a decent fraction of the overall time in my
simple use.
Instead of changing the ownership of
${ANDROID_HOME}instead arrange to runindividual commands under
sudowhen needed.Note that
$PATHis not preserved bysudoso we must use the full path tothe
sdkmanager.Another wrinkle is the cmdline-tools installation, since
tc.extractZipandio.mvdo not include sudo-ish functionality. Instead precreate the targetdirectory with the ownership to allow the unpack as the current user.