Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added subscribeBy(DisposableContainer, [...]) extensions. #241

Open
wants to merge 5 commits into
base: 3.x
Choose a base branch
from

Conversation

mickverm
Copy link
Contributor

@mickverm mickverm commented Aug 10, 2021

RxJava 3.1.0 was released, which contains the following change:

  • API addition: subscribe([...], DisposableContainer) for better Disposable management and reference cleanup.

I've added the following extension methods with named arguments;

Observable<T>.subscribeBy(DisposableContainer, onError, onComplete, onNext)
Flowable<T>.subscribeBy(DisposableContainer, onError, onComplete, onNext)
Single<T>.subscribeBy(DisposableContainer, onError, onSuccess)
Maybe<T>.subscribeBy(DisposableContainer, onError, onComplete, onSuccess)
Completable.subscribeBy(DisposableContainer, onError, onComplete)

⚠️ RxJava 3.1.0 requires minimum Android API 21 (Android 5.0)

@mickverm mickverm force-pushed the rxjava-3.1.0-disposable-management branch from 8d2ee01 to 6c6487c Compare August 10, 2021 07:20
@akarnokd
Copy link
Member

Hi. This repo is quite old and would need to be updated to GitHub Actions. I have no experience with gradle-kotlin so can't really help with it. RxJava's workflows may be a useful template.

@mickverm mickverm force-pushed the rxjava-3.1.0-disposable-management branch from 6c6487c to c67792a Compare August 10, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants