Skip to content

Commit

Permalink
fix(ci): wait on web-component needs sleep, URL is not reliable
Browse files Browse the repository at this point in the history
  • Loading branch information
joanise committed Nov 20, 2024
1 parent d8dc8e3 commit 705d578
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/end-to-end-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
start: |
npx nx serve web-component
npx nx serve-test-data web-component
wait-on: "http://localhost:3333/build/web-component.esm.js"
wait-on: sleep 15 # there is no reliable URL to wait for...
command: npx nx test:once web-component
- name: Check that i18n and l10n are up to date
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/windows-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
start: |
npx nx serve web-component
npx nx serve-test-data web-component
wait-on: "http://localhost:3333/build/web-component.esm.js"
wait-on: sleep 15 # there is no reliable URL to wait for...
command: npx nx test:once web-component

- run: npx nx extract-i18n studio-web
Expand Down

0 comments on commit 705d578

Please sign in to comment.