Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue 108 #250

Merged
merged 15 commits into from
Apr 3, 2024
Merged

fix for issue 108 #250

merged 15 commits into from
Apr 3, 2024

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented Mar 28, 2024

minor change to vertical behaviour scrolling
Closes #108

@deltork deltork requested a review from joanise March 28, 2024 20:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 28, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://ReadAlongs.github.io/Web-Component/pr-preview/pr-250/
on branch gh-pages at 2024-04-03 13:55 UTC

@joanise
Copy link
Member

joanise commented Mar 28, 2024

Did you have a read-along I could test this with?
Such a trivial code change in the end, TS troubleshooting can be so annoying sometimes!

@deltork
Copy link
Collaborator Author

deltork commented Apr 2, 2024 •
edited
Loading

Did you have a read-along I could test this with? Such a trivial code change in the end, TS troubleshooting can be so annoying sometimes!
see ej-fra-long-text.readalong in the test-data folder

joanise
joanise approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this does improve scrolling.

@joanise
Copy link
Member

joanise commented Apr 2, 2024

Please take a moment to rebase the branch onto main before merging, though.

@joanise
Copy link
Member

joanise commented Apr 2, 2024

I.e.,

git fetch
git checkout 108-bug-long-text-highlighting-and-scrolling
git rebase origin/main

then git push -f origin 108-bug-long-text-highlighting-and-scrolling

And maybe also squash all the commits into 1?

deltork and others added 14 commits April 3, 2024 09:50
@deltork
feat: auto-pause at the of each page. Activated via attribute `auto-p…
5bc28bc 
…ause-at-end-of-page`

chore: streamlined sprite emit event loop
@deltork
feat: scrolls to top of page when highlighted word is brought into view
73a4a7b
@joanise @deltork
ci: bump CodeQL workflow to node 20
a976641
@roedoejet @deltork
feat: add web bundle as download option
760074c
@roedoejet @deltork
fix: include review-recommended fixes
0ace949 
	- Update $ style for rxjs variables
	- Add inner folder for zip
	- Use timestamps for filenames
	- Remove indentation for readme
	- Added explicit version for unpkg import
	- Added error handling for zip download promise
@roedoejet @deltork
fix: use human readable timestamp
b653da0
@roedoejet @deltork
docs(i18n): add es and fr translations
53bbd0c
@joanise @deltork
docs(i18n): translate the new message "download failed"
3beb022
@roedoejet @deltork
feat: use slot title as file basename in bundle
338707e
@roedoejet @deltork
feat: use unidecode to create filenames
69896aa
@roedoejet @deltork
fix(assets)!: get rid of useAssetsFolder boolean and replace with ima…
53af947 
…geAssetsFolder string

BREAKING CHANGE: useAssetsFolder is no longer valid.

The equivalent is imageAssetsFolder='assets/' which is the default.
@roedoejet @deltork
fix: check that assets folder ends with /
1bcaf13
@roedoejet @deltork
feat: bump to v1.2.0
d0170df
@roedoejet @deltork
chore: bump single file bundle version
8a1291f
@deltork deltork force-pushed the 108-bug-long-text-highlighting-and-scrolling branch from bf474b9 to 8a1291f Compare April 3, 2024 13:52
@deltork deltork merged commit d003ae0 into main Apr 3, 2024
2 checks passed
@deltork deltork deleted the 108-bug-long-text-highlighting-and-scrolling branch April 3, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanise joanise joanise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"click" play and word is not in view , interface will not focus
3 participants
@deltork @joanise @roedoejet