-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: word press plugin update to address review issues #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
deltork
force-pushed
the
dev.del/wordpress-plugin-update
branch
2 times, most recently
from
May 22, 2024 11:23
8ac3a13
to
20b1f33
Compare
It seems like we're not going to keep this approach, can we close this PR? |
deltork
force-pushed
the
dev.del/wordpress-plugin-update
branch
from
December 4, 2024 18:00
20b1f33
to
5040489
Compare
We are keeping this approach! Just abandoning the plan to put it on WordPress Plugin store. |
joanise
reviewed
Dec 5, 2024
packages/web-component/wordpress-plugin/read-along-web-app-loader/readme.txt
Outdated
Show resolved
Hide resolved
joanise
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
To update the Word Press plugin to address issues raised by review
Fixes?
n/a
Feedback sought?
n/a
Priority?
n/a
Tests added?
n/a
How to test?
n/a
Confidence?
high
Version change?
no