Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: word press plugin update to address review issues #288

Merged
merged 10 commits into from
Dec 6, 2024

Conversation

deltork
Copy link
Collaborator

@deltork deltork commented May 10, 2024

PR Goal?

To update the Word Press plugin to address issues raised by review

Fixes?

n/a

Feedback sought?

n/a

Priority?

n/a

Tests added?

n/a

How to test?

n/a

Confidence?

high

Version change?

no

Copy link
Contributor

github-actions bot commented May 10, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-06 15:49 UTC

@deltork deltork force-pushed the dev.del/wordpress-plugin-update branch 2 times, most recently from 8ac3a13 to 20b1f33 Compare May 22, 2024 11:23
@joanise
Copy link
Member

joanise commented Nov 1, 2024

It seems like we're not going to keep this approach, can we close this PR?

@deltork deltork force-pushed the dev.del/wordpress-plugin-update branch from 20b1f33 to 5040489 Compare December 4, 2024 18:00
@deltork
Copy link
Collaborator Author

deltork commented Dec 4, 2024

It seems like we're not going to keep this approach, can we close this PR?

We are keeping this approach! Just abandoning the plan to put it on WordPress Plugin store.

@deltork deltork marked this pull request as ready for review December 4, 2024 18:12
@deltork deltork requested a review from joanise December 4, 2024 18:12
@deltork deltork requested a review from joanise December 6, 2024 14:39
Copy link
Member

@joanise joanise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@deltork deltork merged commit f0d844a into main Dec 6, 2024
2 checks passed
@deltork deltork deleted the dev.del/wordpress-plugin-update branch December 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants