-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add navbar navigation #322
Conversation
|
Various comments:
As for losing state, it happens in both directions: you also lose your Editor state including all edits you've done if you click on Studio. That's gotta be a deal breaker.
|
I added the fix for the version display to PR for the editor tour |
The privacy dialog issue is as far as I can tell is, cause by some code (current don't if it is us or materials doing this) setting the dialog wrapper style to |
replace download button in component with event emitter
PR Goal?
Add the editor navigation to the main page
Fixes?
Feedback sought?
@deltork can you help with the position of the version element? it's floating in the editor page@deltork similarly do you know why the privacy isn't centered anymore?There's an issue here now where if you navigate to the editor, you lose your progress in the Studio without warning. I think it would be a fairly significant amount of work to systematically ensure that state is maintained/reloaded in services. It's the right thing to do, but it might not happen this week. - I think addressing the state issue is the best solution. I've begun that work here:fixed in : fix state in studio and editor #326Priority?
Tests added?
How to test?
Confidence?
Version change?