fix: always auto-update the browserslist db on deploy #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 1 of 4 files.
|
|
joanise
force-pushed
the
dev.ej/auto-update-browsersdb
branch
from
bb07213 to
77da39c
Compare
|
joanise
force-pushed
the
dev.ej/auto-update-browsersdb
branch
2 times, most recently
from
a7cb3ca to
a88c33e
Compare
joanise
force-pushed
the
dev.ej/auto-update-browsersdb
branch
from
e2b8827 to
e752637
Compare
joanise
added a commit
that referenced
this pull request
Nov 14, 2024
The strategy I implemented in #348 to always update the browserslist-db on install *and commit the results* creates a lot of noise: a lot of similar commits, and we still want to update this db in deploy anyway, so it's not the right strategy. This commit removes the code that commits the changes, and instead updates the db in every workflow that tests or deploys Studio-Web. Furthermore, Del is going to add a build-time dependency that will do this update automatically when you build or serve locally, so we do the same everywhere, automatically, and reasonably quietly.
joanise
added a commit
that referenced
this pull request
Nov 22, 2024
The strategy I implemented in #348 to always update the browserslist-db on install *and commit the results* creates a lot of noise: a lot of similar commits, and we still want to update this db in deploy anyway, so it's not the right strategy. This commit removes the code that commits the changes, and instead updates the db in every workflow that tests or deploys Studio-Web. Furthermore, Del is going to add a build-time dependency that will do this update automatically when you build or serve locally, so we do the same everywhere, automatically, and reasonably quietly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
When we deploy, I often notice this message in the logs:
Instead of trying to remember to do it periodically, it seems wise to just automate it.
This automation here is to update the db and commit the changes when we are testing on a deb branch (i.e., a non-protected branch).
I also fixed some concurrency problems that I noticed while testing this PR.
Priority?
low
Confidence?
high