Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "build(deps-dev): bump express from 4.19.2 to 4.21.0" #353

Closed
wants to merge 16 commits into from

Conversation

joanise
Copy link
Member

@joanise joanise commented Oct 17, 2024

Deliberately revert to a vulnerable dependency version to see GitHub's Dependency Review feature in action.

Do not approve.
Do not merge.

deltork and others added 16 commits September 13, 2024 08:31
*fix: refactoring translations to rely on readalong DOM instead of state (#330)

* fix: refactoring translations to rely on readalong DOM instead of state

* test: fix test for editing readalong

* feat: es and fr translations for layers messages

* fix: refine some translations and text strings

---------

Co-authored-by: Eric Joanis <[email protected]>
Removing all translations / removing all annotations and layers should bring you back to the initial state from which both options are possible.
* fix: display of annotations icon in non edit mode

* fix: updated annotation meta tag delimiter

* fix: update annotation meta id tag name

* chore: clean up
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.21.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/4.21.0/History.md)
- [Commits](expressjs/express@4.19.2...4.21.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps  and [rollup](https://github.com/rollup/rollup). These dependencies needed to be updated together.

Updates `rollup` from 4.14.1 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.14.1...v4.22.4)

Updates `rollup` from 3.29.4 to 4.22.4
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v4.14.1...v4.22.4)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
In CI, let's this npx nx bundle web-component on both Windows and Linux, and on
Linux let's display the diff in a way that we can see the bits that changed
even though it's minified.

To make bundle compatible with Windows, I turned the one liner in `package.json`
into a script that is much easier to read and maintain.
* feat: connect studio tour to editor tour

* chore: updated translations

* fix: implemented feedback from Eric

* chore: translations for the tour connection to the editor

---------

Co-authored-by: Eric Joanis <[email protected]>
* fix: cannot download other formats

* fix: remove xmlns from tags

Fixes #347
Copy link

semanticdiff-com bot commented Oct 17, 2024

Review changes with SemanticDiff.

Analyzed 1 of 1 files.

Filename Status
✔️ package-lock.json 51.05% smaller

Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://ReadAlongs.github.io/Studio-Web/pr-preview/pr-353/
on branch gh-pages at 2024-10-17 19:01 UTC

@joanise joanise closed this Oct 17, 2024
@joanise joanise deleted the dev.ej/test-dependency-review branch October 17, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants