chore: extended plausible events to include editor (#345) #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 4 of 4 files. Overall, the semantic diff is 11% smaller than the GitHub diff.
|
|
|
Looks good! |
deltork
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
Reinsert the code to report Editor events to plausible, thus re-applying #345 to reverted main.
Fixes?
Reports editor events, and download types, to Plausible.
Feedback sought?
sanity checking
Priority?
medium
Tests added?
no
How to test?
on the PR preview, opt in to analytics and see that Editor-related events get reported. Don't forget to opt back out of analytics after!
Confidence?
medium
Version change?
no