This repository has been archived by the owner on Jul 18, 2019. It is now read-only.
First pass at adding resource requests to foreman. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are very rough guesses based on what I see in SysDig relative to the default request.cpu (2m).
kr3cj
approved these changes
Aug 19, 2018
| @@ -27,6 +27,10 @@ spec: | |||
| - name: {{ .Chart.Name }} | |||
| image: "{{ .Values.utilitypod.image.repository }}:{{ .Values.utilitypod.image.tag }}" | |||
| imagePullPolicy: Always | |||
| resources: | |||
| request: | |||
| cpu: 10m | |||
There was a problem hiding this comment.
You may have already seen this but I believe 10m means ten millicpu: https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/#meaning-of-cpu
There was a problem hiding this comment.
Correct. The default value is 2m, and sysdig says it's not even using that.
I don't like giving containers such tiny numbers. That's a great way to shoot yourself in the foot later, when a deployment needs to actually do something. I generally don't like going below 50m without a lot of history, but this one shows no CPU pulled for the whole 2 weeks visible in sysdig.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are very rough guesses based on what I see in SysDig relative to
the default request.cpu (2m).