Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for 0.8.6 - works with 0.7.x #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

lupestro
Copy link

@lupestro lupestro commented Jun 6, 2021

Completed testing patch this morning. All functions appear to work reliably on both versions, except for a couple of very intermittent flakes only on Dancing Lights:

  • in 0.8.x only, I once got things into a state where setting a token document flag to "Dancing Lights"wasn't "taking" - so it never attempted the deletion. Meanwhile setting this flag was working flawlessly for other tokens - weird! They can still be removed manually, of course.
  • In 0.7.x only, I encountered a situation where the GM deleted the lights but they only went away for the GM. As I logged other players in, everyone else could still see them. The GM needed to log out and log back in to delete them manually.

These issues don't happen at all consistently, making them difficult to reproduce, and I think the module as a whole is in better shape than it was - plus all the functions are working in 0.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant