[CORE] fix a small bug in the network holder

Due to the async flag, the network holder does not wait for the shared preferences to be loaded and return invalid arguments.
ReceiptManager · Feb 19, 2021 · 02817fa · 02817fa
1 parent e2a1c99
commit 02817fa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lib/network/network_client_holder.dart b/lib/network/network_client_holder.dart
@@ -52,17 +52,14 @@ class NetworkClientHolder {
   /// Show receipt article list
   bool showItemList;
 
-  SharedPreferences sharedPrefs;
-
   static final NetworkClientHolder _networkClientHolder =
       NetworkClientHolder._internal();
 
   NetworkClientHolder._internal();
   factory NetworkClientHolder() {
     return _networkClientHolder;
   }
-  void readOptions() async {
-    sharedPrefs = await SharedPreferences.getInstance();
+  void readOptions(SharedPreferences sharedPrefs) {
     ip = sharedPrefs.get("ipv4");
     token = sharedPrefs.get("api_token");
     sendDebugOutput = sharedPrefs.get("enable_debug_output");

diff --git a/lib/ui/parser/display_image.dart b/lib/ui/parser/display_image.dart
@@ -23,6 +23,7 @@ import 'package:receipt_manager/generated/l10n.dart';
 import 'package:receipt_manager/network/network_client.dart';
 import 'package:receipt_manager/network/network_client_holder.dart';
 import 'package:rounded_loading_button/rounded_loading_button.dart';
+import 'package:shared_preferences/shared_preferences.dart';
 
 class DisplayPictureScreen extends StatefulWidget {
   final String imagePath;
@@ -115,7 +116,9 @@ class DisplayPictureScreenState extends State<DisplayPictureScreen> {
                                     _declineButtonColor = Colors.grey;
                                   });
 
-                                  holder.readOptions();
+                                  SharedPreferences sharedPrefs =
+                                      await SharedPreferences.getInstance();
+                                  holder.readOptions(sharedPrefs);
 
                                   await client.sendImage(
                                       File(imagePath), holder, context, key2);