Skip to content

ci : 릴리즈 브랜치가 유효한지 검사하는 ci 작성#201

Merged
hegunhee merged 4 commits into
mainfrom
feature/release-ci
Apr 6, 2026
Merged

ci : 릴리즈 브랜치가 유효한지 검사하는 ci 작성#201
hegunhee merged 4 commits into
mainfrom
feature/release-ci

Conversation

@hegunhee
Copy link
Copy Markdown
Member

@hegunhee hegunhee commented Apr 6, 2026

🔗 관련 이슈

📙 작업 설명
릴리즈 노트가 있는지 확인하고 현재 브랜치의 버전코드와 릴리즈 브랜치의 버전코드를 비교하는 코드 작성

🧪 테스트 내역 (선택)

📸 스크린샷 또는 시연 영상 (선택)

💬 추가 설명 or 리뷰 포인트 (선택)

Summary by CodeRabbit

릴리스 노트

  • Chores
    • 릴리스 프로세스 개선을 위한 자동화된 검증 시스템 추가
    • 릴리스 버전 일관성 및 문서화 검증 강화

@hegunhee hegunhee self-assigned this Apr 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 6, 2026

Warning

Rate limit exceeded

@hegunhee has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 43 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 43 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a532b13c-cb2e-47b9-bd9b-7524924910ff

📥 Commits

Reviewing files that changed from the base of the PR and between 0096f07 and c6f12c3.

📒 Files selected for processing (1)
  • .github/workflows/validate-release.yml

Walkthrough

새로운 GitHub Actions 워크플로우 파일을 추가하여 릴리스 PR에서 versionCode 증가를 검증하고 릴리스 노트 파일 존재 여부를 확인합니다. release- 접두사로 시작하는 브랜치의 PR에서만 실행되며, 버전 코드 비교 및 릴리스 노트 검증에 실패하면 작업을 중단합니다.

Changes

코호트 / 파일 요약
릴리스 검증 워크플로우
.github/workflows/validate-release.yml
PR과 main 브랜치의 versionCode 값을 비교하여 PR의 버전이 더 큰지 확인하고, docs/releaseNote/v<version>/release.md 릴리스 노트 파일의 존재 여부를 검증하는 새로운 GitHub Actions 워크플로우 추가.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • [ANDROID-200] 1.0.2 release #188: 이 PR은 app/build.gradle.ktsversionCode 증가와 docs/releaseNote/v<version>/release.md 릴리스 노트 추가를 포함하고 있어, 새로 추가된 검증 워크플로우와 직접적인 연관이 있습니다.

Poem

🐰 릴리스 브랜치를 점검하는 토끼,
버전 번호와 노트를 살펴보며,
숫자가 올라가고 파일이 있으면,
환호성 지르며 배포 준비 완료! 🎉
자동화의 마법으로 안전하게! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed PR 제목이 변경사항의 주요 내용을 명확하게 설명하고 있습니다. 릴리즈 브랜치 검증 CI 작성이라는 핵심 목적이 잘 드러나 있습니다.
Description check ✅ Passed PR 설명이 저장소의 템플릿 구조를 따르고 있으나, 관련 이슈 섹션이 비어있고 테스트/스크린샷/추가 설명 항목이 미작성되어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/release-ci

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/validate-release.yml:
- Around line 37-38: The current extraction of CURRENT_VERSION_CODE using sed
with a strict spacing pattern is brittle and can produce an empty string that
bypasses numeric comparison; change the extraction to a robust regex that
captures digits (e.g., use grep -oE or awk to find "versionCode" and the numeric
value allowing optional spaces), assign that numeric substring to
CURRENT_VERSION_CODE, then validate it with a numeric check (e.g., test with a
regex like ^[0-9]+$ or use bash arithmetic) and fail/exit non-zero if empty or
non-numeric; only echo "current_version_code=$CURRENT_VERSION_CODE" to
GITHUB_OUTPUT after the validation passes so invalid or missing versionCode
cannot silently pass.
- Around line 26-31: The workflow is directly inserting github.head_ref into an
inline shell which risks script injection; modify the "extract-version" step to
pass github.head_ref via the step env (e.g., set an env variable like
BRANCH_NAME: ${{ github.head_ref }}) and then reference that env variable inside
the run block to compute VERSION (using safe shell expansion and your existing
sed on $BRANCH_NAME) so the value is never interpolated into the script source
itself; update references to BRANCH_NAME and VERSION in the step accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9118f5a8-4fef-46fc-9f42-e0f7d2092608

📥 Commits

Reviewing files that changed from the base of the PR and between 4a1cd91 and 0096f07.

📒 Files selected for processing (1)
  • .github/workflows/validate-release.yml

Comment thread .github/workflows/validate-release.yml
Comment thread .github/workflows/validate-release.yml Outdated
@hegunhee hegunhee merged commit c759c2b into main Apr 6, 2026
1 check passed
@coderabbitai coderabbitai Bot mentioned this pull request Apr 6, 2026
@hegunhee hegunhee deleted the feature/release-ci branch April 6, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant