Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show amount error #37

Merged
merged 4 commits into from
Dec 2, 2019
Merged

Always show amount error #37

merged 4 commits into from
Dec 2, 2019

Conversation

Ugoku
Copy link
Member

@Ugoku Ugoku commented Nov 28, 2019

Testing this is near impossible with just unit testing :/ I've created #36 to implement Selenium testing, which would make testing certain things much easier.

Closes #35

@nederdirk
Copy link
Contributor

@Ugoku Could we mock/spy on setMinMaxAmountWarning to test whether the expected error messages are displayed?

@Ugoku
Copy link
Member Author

Ugoku commented Nov 28, 2019

@nederdirk yes we can!

@Ugoku Ugoku requested a review from nederdirk December 2, 2019 08:46
@nederdirk nederdirk merged commit 43f57c6 into master Dec 2, 2019
@Ugoku Ugoku deleted the 35-always-show-amount-error branch December 18, 2019 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering too high amount doesn't always give an error
2 participants