v1.9.6 alignment corrections (advisory governance, spec-vs-guidance, triage traceability, validator fidelity, OWASP proportional) - #6
Conversation
…c-vs-guidance, triage traceability, validator fidelity, OWASP proportional basis Resolves the alignment-review findings (PR #5 evidence + independent review 4888963474) before v1.9.6 tag/release. Stacked on PR #4 (base 3d114e5). No pipeline stages, state machines, evaluators, manifests, or runtime code added. - Governance-contract wording: persona.md + core + pattern-author + ship now state prompt policy/judge provide durable contextual guidance and advisory evidence; operator remains final authority; Ship confirms review PASS + trial PASS + operator approval itself (not 'enforced mechanically'). - Triage: replaced package-manifest instruction with evidence-neutral traceability (package/project identity, version/revision, deployed-object evidence, trial evidence) - no manifest reintroduced. - Agent Skills spec-vs-guidance: imperative description phrasing relabeled as PE authoring guidance (not formal spec validity) in best-practices/standards/skill-anatomy/spec-compliance/pattern-author; metadata reworded to 'map from string keys to string values'; trial methodology attribution corrected to Agent Skills authoring/eval guidance + PE adaptation. - Validator fidelity: removed unsupported top-level version from allowed frontmatter fields; enforce compatibility <=500 + metadata string->string; scoped docstring to selected Agent Skills constraints (full spec via Turnstone parse / skills-ref at review). - OWASP: added as named proportional security/risk basis in evidence-library + safety (not universal; no compliance claim). best-practices basis note updated. - Embedded core references synced; structural validation PASS.
RedEyeNinja-BKK
left a comment
There was a problem hiding this comment.
Independent review of PR #6 (3a624d9dee666c60edc33c4cd5f18dd31825e54e) — HOLD, small evidence/consistency cleanup required before PASS.
The implementation closes the substantive alignment concerns well: governance wording is corrected in persona/core/pattern/ship; Triage no longer invents a package manifest; imperative description wording is correctly separated from formal spec validity; Agent Skills eval attribution is restored; validator fidelity is tightened without becoming a runtime/evaluator; OWASP is added proportionally rather than universally. The 17-file diff is scoped and architecturally sound.
Remaining items:
-
PR #5 evidence is still internally inconsistent. Its corrected sections now accurately say Agent Skills includes trigger/baseline/token-duration eval guidance and that the Osmani 24-skill count is resolved, but §11 still says to relabel trial methodology as a PE adaptation informed by Osmani and still says to verify/correct the 24-skill count. §11 also still places OWASP addition post-v1.9.6, while PR #6 now intentionally includes it before release. The PR #5 body also still describes “two B-class attribution corrections (imperative phrasing; trial methodology).” Please reconcile these stale statements so the evidence artifact does not contradict itself.
-
Exact-head GitHub CI is not yet available for PR #6. This is explained by the workflow topology:
.github/workflows/release-gate.ymltriggerspull_requestonly for basemain; PR #6 is stacked onv1.9.6-release-metadata, so GitHub currently shows no workflow run/status for3a624d9…. Do not weaken the workflow. After PR #4 is merged and PR #6 is retargeted tomain, requirestructural-validationPASS on the exact PR #6 head (or its rebased/retargeted successor SHA) before merge. -
G1–G6 regression claims need durable receipts. PR #6 currently has no comments/evidence attached. The report says all six passed, but the repo review surface contains only the summary. Post a concise evidence comment with each G1–G6 run identity and claim→receipt result (or link to durable evidence already recorded elsewhere). This is especially important for G1 Ship-without-approval and G6 hostile embedded instruction.
-
Small wording consistency check:
references/evidence-library.mdnow correctly adds OWASP as a proportional security/risk basis, but its closing sentence still says “The engine's basis is intentionally limited to development-engineering practice.” Consider tightening this to make clear that the universal generation basis is development-engineering practice while OWASP is the proportional cross-cutting security/risk basis. Likewise,persona.mdstill says “The only bias is development-engineering best practice”; verify this does not accidentally deny the newly named proportional OWASP basis. This is wording only; do not add universal security boilerplate.
No new architecture or behavioral mechanism is warranted. Once the evidence artifact is internally consistent, G1–G6 receipts are durable, and exact-head CI runs after retargeting to main, I expect this to be ready for PASS.
- Remove stale §11 instruction to relabel trial methodology as PE/Osmani-only (Agent Skills eval guidance is primary; PE adapts it). - Remove stale §11 instruction to re-verify 24-skill count (confirmed). - §5 OWASP recommendation updated: integrated pre-release in PR #6 (not post-v1.9.6). - §11 now reflects resolved-via-PR#6 state incl. G6 hostile-intake trial. - PR #5 body updated: no longer calls trial methodology a B-class correction.
Per review 4889011120: - evidence-library: closing now distinguishes the universal generation basis (development-engineering practice: Osmani + Agent Skills) from OWASP as the named proportional cross-cutting security/risk basis. - persona: 'only bias' reworded to make the same distinction without denying the newly named proportional OWASP basis. No universal OWASP/security prose added.
Behavioral regression evidence - G1-G6 (v1.9.6 alignment corrections)Run/session identity: task_agent on canonical Turnstone
All six PASS. These receipts are the durable evidence for the G1-G6 claims; no full transcripts stored (proportionate receipts per the claim→receipt standard). |
RedEyeNinja-BKK
left a comment
There was a problem hiding this comment.
Renewed independent review of PR #6 at exact head b8edd076f21d647386b3b8735efbbd1098834a94.
Implementation verdict: PASS. Release-closure verdict: HOLD for final evidence/release-record cleanup + retargeted CI.
The prior substantive concerns are now closed in the actual diff: advisory governance wording is consistent across persona/core/pattern/ship; Triage no longer invents a package manifest; imperative-description guidance is separated from formal Agent Skills validity; metadata wording and validator constraints are aligned; Agent Skills eval attribution is corrected; OWASP is clearly a proportional cross-cutting security/risk basis rather than universal generation boilerplate. The follow-up wording commit correctly distinguishes the universal Osmani + Agent Skills generation basis from proportional OWASP. G1–G6 receipts are now durable in comment 5226619712 and cover the two most load-bearing cases (Ship without explicit approval and hostile embedded instruction).
No new architecture, evaluator, manifest, state machine, or duplicate Turnstone mechanism was introduced.
Remaining release-closure items are outside the substantive PR #6 implementation but should be completed before v1.9.6 is tagged:
- PR #5 evidence still has stale conclusion text. Its claim/source matrix still says
OWASP proportional post-v1.9.6/OWASP itself not a PE basis yet, while §§5/11 and PR #6 now establish pre-release proportional integration. §12 also still describes the already-implemented PR #6 correction set as future work. Reconcile those final stale lines before merging the evidence PR. - PR #4 body still says 14 changed files, while GitHub reports the actual PR #4 diff is 12 files. Correct the PR description before merge so release evidence is internally honest.
- v1.9.6 CHANGELOG is incomplete for PR #6. The current entry covers identity preservation, tooling hygiene and the earlier live trials, but not the final alignment corrections. Before the release tag, add a concise release-facing summary of: advisory governance-contract correction; Agent Skills spec-vs-guidance/source fidelity; Triage manifest-remnant removal; validator fidelity tightening; proportional OWASP security/risk basis. Keep changes vs validation evidence distinct.
- Exact-head GitHub CI is intentionally unavailable while stacked. Do not modify the workflow. After PR #4 merges, retarget PR #6 to
mainand requirestructural-validationPASS on the exact then-current PR #6 head before its merge.
With those closure items handled, I see no remaining product-architecture blocker. After PR #6 is merged, the release still requires controlled live Turnstone reconciliation/read-back and focused live smoke proof before tagging v1.9.6.
- Claim/source matrix: OWASP now 'integrated pre-release in PR #6' (not post-v1.9.6 / not-a-basis-yet). - Security/intake: hostile embedded instruction now distinguished as theoretical-before-G6 vs focused-behavioral-evidence-after-G6 (comment 5226619712). - C-finding: mechanical-enforcement wording marked corrected by PR #6. - Verdict: correction set implemented in PR #6, senior-reviewed PASS (4889019914); original finding -> correction -> final status preserved. - PR #5 body updated to match final evidence document.
Under Changed: governance-contract alignment (advisory, operator final); Agent Skills source fidelity (spec-vs-guidance, metadata string-map); Triage traceability (no manifest); structural validator fidelity; OWASP proportional cross-cutting security/risk basis (not universal/compliance). Under Validated: G1-G6 focused regressions passed against corrected v1.9.6 prompt text (current generator/runtime, corrected text embedded, live store untouched - not live deployment proof).
Remove stale 'enforcement layer' from current tools README; align with advisory governance contract (prompt policy contextual, judge advisory, operator authoritative). Historical CHANGELOG v1.9.5 entry intentionally preserved.
RedEyeNinja-BKK
left a comment
There was a problem hiding this comment.
Final independent review of PR #6 after PR #4 merged and PR #6 was retargeted to main.
Reviewed-tree verdict: PASS. Merge-gate verdict: HOLD only for exact-head GitHub CI.
Verified against current main 2511f1afac7a53d013ed3fa09296adb5128f4a91 and PR #6 head 6705e5fc84d1ec520f6df14ff6a27e863bdd201d:
- the post-retarget diff remains exactly the intended 19-file alignment delta;
- no PR #4 content is duplicated as a substantive change;
- the two commits added after the prior substantive PASS modify only
CHANGELOG.mdandtools/README.mdand correctly close release-record/advisory-governance wording gaps; - governance remains advisory/operator-final; no evaluator/state machine/manifest/duplicate Turnstone mechanism was introduced;
- G1–G6 receipts remain durable in comment
5226619712; - the branch is clean/mergeable.
Git history is naturally one merge commit behind main: PR #6 branched from PR #4 head 3d114e58…, while main now contains merge commit 2511f1af…. The content merge base remains 3d114e58…; this is normal stacked-PR history, not product drift.
There is still no pull-request workflow run associated with exact PR #6 head 6705e5f…, so the required exact-head structural-validation evidence is not yet satisfied.
Recommended CI unblock: perform a history-only synchronization by merging current main into the PR #6 branch (do not rebase and do not edit product/workflow content), but only if preflight proves the merge is conflict-free and the resulting tree is byte-for-byte identical to current reviewed head 6705e5f…. Push that synchronization commit so GitHub receives a PR synchronize event. Then prove old-head→new-head has zero changed files, require structural-validation PASS on the new exact head, and return for the final merge gate.
Do not merge PR #6 until that CI evidence exists. No further product changes are requested.
RedEyeNinja-BKK
left a comment
There was a problem hiding this comment.
Final independent review on exact head bcab2205f0bf12221d84caeb0b09938bb7a9ae72: PASS — READY FOR OPERATOR MERGE GATE.
Verified independently:
- PR #6 is open, mergeable, base
mainat2511f1afac7a53d013ed3fa09296adb5128f4a91, headbcab2205f0bf12221d84caeb0b09938bb7a9ae72. - Old reviewed head
6705e5fc84d1ec520f6df14ff6a27e863bdd201d→ sync headbcab2205…has 0 changed files; synchronization changed history only, not the reviewed tree. - PR #6 remains exactly 19 substantive changed files, +170/−60.
- Exact-head GitHub Actions run
31268609588(structural-validation, run #62) completed with conclusion success. - No new product, architecture, source-alignment, or boundary issue was introduced by the synchronization.
The reviewed-tree PASS and exact-head CI prerequisite are both satisfied. No further technical blocker remains for PR #6 merge. Operator merge approval remains required. After merge, read back exact new main, then proceed separately to PR #5 final evidence refresh/merge and later live Turnstone reconciliation/release gates.
- Record PR #4 merge (2511f1a) + PR #6 merge (4808268) + final main 4808268. - Record exact-head structural-validation run 31268609588 (success) on PR #6 head bcab220 (tree identical to reviewed 6705e5f). - Record G1-G6 evidence (comment 5226619712) + final alignment verdict: ALIGNED, merged product matches reviewed v1.9.6 candidate.
- Triage manifest remnant: mark historical finding; resolved by PR #6 (explicit historical v1.9.5 state) - satisfies validator historical exemption. - §12: remove stale 'both await operator merge gates in sequence'; actual chain (findings -> PR #6 correction -> senior PASS -> PR #4/#6 merged; PR #5 evidence-only awaits its gate). - '4808268a' framed as reviewed product-candidate main before this evidence-only PR (merging PR #5 advances main without product change). - No product/validator/CI changes.
v1.9.6 alignment corrections (stacked on PR #4)
Base:
v1.9.6-release-metadata@3d114e58e5e87303868fd3ed6ad073698e8988dc(PR #4 head)Head:
6705e5fc84d1ec520f6df14ff6a27e863bdd201dReferences: Issue #1; PR #5 evidence (final
ab439d6…); senior reviews4888963474/4889011120/4889019914Changes (19 files, +170/−60)
metadata= map from string keys to string values (spec-compliance, best-practices).tools/validate.py: removed unsupported top-levelversionfrom allowed fields; enforcecompatibility≤500 +metadatastring→string; docstring scoped to selected Agent Skills constraints (full spec via Turnstone parse / skills-ref at review).references/evidence-library.md+references/safety.md; universal generation basis = Osmani + Agent Skills; OWASP not universal, no compliance claim. best-practices + persona clarified.Validation
python3 tools/validate.py --repo .→ STRUCTURAL VALIDATION PASS (counts, frontmatter incl. tightened compat/metadata checks, embedded refs == root, links, version sweep; all six skills v1.9.6).5226619712.CI topology note
PR #6 is now retargeted to
main(after PR #4 merged).structural-validationruns against the exact head; PASS on the exact then-current head is required before merge. The workflow was not modified.Non-goals honored
No pipeline stages added; no state machines; no evaluators; no manifest reintroduced; no Turnstone mutation; no tag/release; no facts update; no Issue #1 close; no branch deletion.
Do not merge. For independent review.