docs(icon): remove sets demo#2088
Merged
bennypowers merged 13 commits intomainfrom Mar 25, 2025
Merged
Conversation
Users should instead see https://ux.redhat.com/foundations/typography
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
Size Change: 0 B Total Size: 202 kB ℹ️ View Unchanged
|
zeroedin
reviewed
Dec 13, 2024
Collaborator
zeroedin
left a comment
zeroedin
left a comment
There was a problem hiding this comment.
We should add an alert at the top of the rh-icon demo page rerouting people to the iconography page. There has been confusion about where to find the icons with the users I've worked with, this would be helpful.
<rh-alert state="info">
<h2 slot="header">Looking for the icons?</h2>
<p>All the icons you might need are right at your fingertips! Head over to our <a href="/foundations/iconography/">iconongraphy</a> foundations page to explore the full collection.</p>
</rh-alert>or something to this effect
Collaborator
|
@bennypowers I went ahead and dropped a commit adding that alert with the link to the iconography page for your review code wise. @marionnegp what are your thoughts on this? Let me know if you want the language changed. |
marionnegp
requested changes
Jan 9, 2025
marionnegp
previously requested changes
Mar 24, 2025
if authors add elements/*/docs/90-demos.md, that content should be prepended to the demos page
bennypowers
dismissed
marionnegp’s stale review
comma resolved. thanks for the review
marionnegp
approved these changes
Mar 25, 2025
github-project-automation
Bot
moved this from Review 🔍
to Done ☑️
in Red Hat Design System
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users should instead see https://ux.redhat.com/foundations/typography
What I did