chore(deps): Correct utils package deps #2066
Conversation
bastilian
force-pushed
the
fix_utils_deps_intl
branch
from
c8371fe
to
c574250
Compare
react-intl and redux mock store are used in the `TestWrapper` component and should be proper dependencies.
mkholjuraev
force-pushed
the
fix_utils_deps_intl
branch
from
c574250
to
d6848f4
Compare
| "react-content-loader": "^6.2.0" | ||
| "react-content-loader": "^6.2.0", | ||
| "react-intl": "^6.6.8", | ||
| "redux-mock-store": "^1.5.4" |
There was a problem hiding this comment.
should these packages be direct dependency even if we use them for testing purposes?
There was a problem hiding this comment.
@mkholjuraev If they are imported and used they should be dependencies. If we could expect that all apps, always have these dependencies as well, we should still add them as dependencies, but in that case we'd make them "peerDependencies".
However, we can not expect our apps to really always, for sure, to have these dependencies and we are not making it possible to use the Wrapper without these dependencies. So we should add them, or apps may unnecessarily have to add these as a dependency themselves, which we should avoid.
There was a problem hiding this comment.
I am just concerned that some devDepencies in nature are being added as direct dependency. Honestly, I do not have a clear understanding of the problem stated thus, I would like to request someone else as a reviewer.
react-intl and redux mock store are used in the
TestWrappercomponent and should be proper dependencies.