Ensure analytics observer instance is not lost.

src/analytics/SegmentProvider.tsx

@@ -75,15 +75,21 @@ const getAPIKey = (env: SegmentEnvs = 'dev', module: SegmentModules, moduleAPIKe
   }[env]?.[module] ||
   KEY_FALLBACK[env];
 
+let observer: MutationObserver | undefined;
 const registerAnalyticsObserver = () => {
+  // never override the observer
+  if (observer) {
+    return;
+  }
+  console.log('Calling register observer');
   /**
    * We ignore hash changes
    * Hashes only have frontend effect
    */
   let oldHref = document.location.href.replace(/#.*$/, '');
 
   const bodyList = document.body;
-  const observer = new MutationObserver((mutations) => {
+  observer = new MutationObserver((mutations) => {
     mutations.forEach(() => {
       const newLocation = document.location.href.replace(/#.*$/, '');
       if (oldHref !== newLocation) {
@@ -99,7 +105,6 @@ const registerAnalyticsObserver = () => {
     childList: true,
     subtree: true,
   });
-  return observer.disconnect;
 };
 
 const isInternal = (email = '') => /@(redhat\.com|.*ibm\.com)$/gi.test(email);
@@ -255,8 +260,11 @@ const SegmentProvider: React.FC<SegmentProviderProps> = ({ activeModule, childre
   };
 
   useEffect(() => {
-    const disconnect = registerAnalyticsObserver();
-    return () => disconnect();
+    registerAnalyticsObserver();
+    return () => {
+      observer?.disconnect();
+      observer = undefined;
+    };
   }, []);
 
   useEffect(() => {