Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WS client for chrome service. #2525

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented May 23, 2023

@Hyperkid123 Hyperkid123 marked this pull request as draft May 23, 2023 12:44
@Hyperkid123 Hyperkid123 requested a review from a team May 23, 2023 13:20
@Hyperkid123 Hyperkid123 marked this pull request as ready for review June 8, 2023 14:24
@Hyperkid123
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

Codecov Report

Merging #2525 (d38422a) into master (9644139) will decrease coverage by 0.31%.
The diff coverage is 46.51%.

❗ Current head d38422a differs from pull request most recent head 27ce86e. Consider uploading reports for the commit 27ce86e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2525      +/-   ##
==========================================
- Coverage   58.01%   57.71%   -0.31%     
==========================================
  Files          91       90       -1     
  Lines        2706     2722      +16     
  Branches      641      640       -1     
==========================================
+ Hits         1570     1571       +1     
- Misses       1135     1150      +15     
  Partials        1        1              
Impacted Files Coverage Δ
src/hooks/useChromeServiceEvents.ts 43.90% <43.90%> (ø)
src/jwt/jwt.ts 75.40% <100.00%> (+0.19%) ⬆️

... and 7 files with indirect coverage changes

@Hyperkid123
Copy link
Contributor Author

/retest

@Hyperkid123
Copy link
Contributor Author

/retest

@Hyperkid123 Hyperkid123 merged commit 681ed1a into RedHatInsights:master Jul 11, 2023
6 checks passed
@Hyperkid123 Hyperkid123 deleted the ws-client branch July 11, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants