Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename subs bundle to match the route. #2562

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Rename subs bundle to match the route. #2562

merged 2 commits into from
Jul 11, 2023

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Jul 10, 2023 •
edited
Loading

@Hyperkid123 Hyperkid123 requested a review from a team July 10, 2023 07:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023 •
edited
Loading

Codecov Report

Merging #2562 (2c13b6a) into master (d74a689) will not change coverage.
The diff coverage is 66.66%.

❗ Current head 2c13b6a differs from pull request most recent head 132283f. Consider uploading reports for the commit 132283f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2562    +/-   ##
========================================
  Coverage   58.09%   58.09%            
========================================
  Files          91       91            
  Lines        2713     2713            
  Branches      697      643    -54     
========================================
  Hits         1576     1576            
- Misses       1026     1136   +110     
+ Partials      111        1   -110
Impacted Files Coverage Δ
src/hooks/useBreadcrumbsLinks.ts 76.66% <0.00%> (ø)
src/components/AppFilter/useAppFilter.ts 94.62% <100.00%> (ø)

... and 29 files with indirect coverage changes

@Hyperkid123
Copy link
Contributor Author

/retest

@Hyperkid123 Hyperkid123 merged commit 8b94ab8 into RedHatInsights:master Jul 11, 2023
6 checks passed
@Hyperkid123 Hyperkid123 deleted the rename-subscripstions-bundle branch July 11, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelhala karelhala karelhala approved these changes

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hyperkid123 @codecov-commenter @karelhala