Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'fake' services to be favorited #2567

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Allow 'fake' services to be favorited #2567

merged 3 commits into from
Jul 13, 2023

Conversation

apinkert
Copy link
Contributor

For RHCLOUD-25323. Previously 'Create Cluster' could be favorited from the 'Containers' menu, but would not show up under a user's favorite services.

image

@apinkert apinkert requested a review from a team July 12, 2023 13:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #2567 (8fce1bb) into master (2c6f60a) will decrease coverage by 0.05%.
The diff coverage is 46.15%.

❗ Current head 8fce1bb differs from pull request most recent head f29ebe7. Consider uploading reports for the commit f29ebe7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
- Coverage   57.91%   57.86%   -0.05%     
==========================================
  Files          92       92              
  Lines        2756     2767      +11     
  Branches      702      651      -51     
==========================================
+ Hits         1596     1601       +5     
- Misses       1048     1165     +117     
+ Partials      112        1     -111     
Impacted Files Coverage Δ
src/hooks/useAllServices.ts 29.72% <ø> (ø)
src/hooks/useFavoritedServices.ts 50.00% <46.15%> (-1.62%) ⬇️

... and 29 files with indirect coverage changes

@Hyperkid123 Hyperkid123 merged commit 31973f8 into master Jul 13, 2023
7 checks passed
@Hyperkid123 Hyperkid123 deleted the fake-bundle branch July 13, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants