[RHINENG-663] - Add subtitle property in AllServices #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2576 +/- ##
========================================
Coverage 57.72% 57.72%
========================================
Files 92 92
Lines 2775 2775
Branches 707 653 -54
========================================
Hits 1602 1602
- Misses 1059 1172 +113
+ Partials 114 1 -113
|
Hyperkid123
requested changes
Jul 19, 2023
There was a problem hiding this comment.
Is it possible to use the product field for the subtitle here?
@AsToNlele unfortunately we can't as it would impact other tiles that do want to use the product as a subtitle and have the product defined in their links. I would suggest creating a new attribute inside the Chrome service as that instead.
AsToNlele
force-pushed
the
RHINENG-663
branch
2 times, most recently
from
e44fd49
to
7f06c74
Compare
AsToNlele
changed the title
|
I've added |
Hyperkid123
reviewed
Jul 20, 2023
|
|
||
| do not show bundle if the card title matches bundle title | ||
| */} | ||
| <Text component="small">{subtitle ? subtitle : bundle !== title ? bundle : null}</Text> |
There was a problem hiding this comment.
Can you change this to not use multiple ternary statements? To something like
subtitle || (bundle !== title ? bundle : null)
Hyperkid123
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHINENG-663
Is it possible to use the
productfield for the subtitle here?At first I tried changing the bundle names, but that would not work for some ansible items
RedHatInsights/chrome-service-backend#228 depends on this PR