Make cookie consent dismissable in mobile #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epwinchell
requested review from
Hyperkid123,
ryelo and
karelhala
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2603 +/- ##
========================================
Coverage 57.60% 57.60%
========================================
Files 92 92
Lines 2788 2788
Branches 711 656 -55
========================================
Hits 1606 1606
- Misses 1066 1181 +115
+ Partials 116 1 -115 |
|
/retest |
Hyperkid123
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/RHCLOUD-27360
Tested on iPhone 14 (Safari & Chrome) and Samsung Galaxy S23 (Chrome)
Old
New
