Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path matching in Caddyfile: #2604

Merged
merged 5 commits into from
Aug 4, 2023

Conversation

adamrdrew
Copy link
Contributor

Path matching in the Caddyfile has been broken for a long time, we just never noticed because we were serving out the same content over every route and akamai was covering over the difference with rewrites. Now that akamai is fixed and our standard caddy config has changed the problem in chrome is biting us. I tested this locally by downloading the latest chrome image, running it locally docker, confirming I couldn't get anything over beta routes, making the change, and confirming it works.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Merging #2604 (7d5b43d) into master (6c7d623) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d5b43d differs from pull request most recent head be8219e. Consider uploading reports for the commit be8219e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2604    +/-   ##
========================================
  Coverage   57.60%   57.60%            
========================================
  Files          92       92            
  Lines        2788     2788            
  Branches      711      656    -55     
========================================
  Hits         1606     1606            
- Misses       1066     1181   +115     
+ Partials      116        1   -115     

see 31 files with indirect coverage changes

@ryelo ryelo merged commit 785fdf5 into RedHatInsights:master Aug 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants