Integrate Keycloak in int and scr env #2609
Conversation
aneelac22
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2609 +/- ##
==========================================
+ Coverage 57.57% 57.62% +0.05%
==========================================
Files 92 91 -1
Lines 2786 2773 -13
Branches 711 656 -55
==========================================
- Hits 1604 1598 -6
- Misses 1066 1174 +108
+ Partials 116 1 -115
|
| portal: 'https://ephem.outsrights.cc/', | ||
| }, | ||
| int: { | ||
| url: ['console.int.openshiftusgov.com'], |
There was a problem hiding this comment.
Would it not be better to allow these URLs to be configured when building the assets via env variables and avoid exposing URLs like these on GitHub?
There was a problem hiding this comment.
@bastilian we configure the SSOUrl for our environments in the frontend operator and the values are not public. However, the specific environment of this PR is not yet using the frontend operator. It's in the process of migration. The same applies to the qaprodauht. Until qaprodauth is discontinued and all envs are using the FEO, we need these values still.
| @@ -134,7 +136,7 @@ export const doOffline = (key: string, val: string, configSsoUrl?: string) => { | |||
| scopes.push(partnerScope); | |||
| } | |||
|
|
|||
| if (ssoScopes) { | |||
| if (ssoScopes && !itLessKeycloakEnv) { | |||
There was a problem hiding this comment.
Just a double-check. The offline token is not supposed to have all SSO scopes of the current session?
There was a problem hiding this comment.
There are no scopes in fedramp and this step is not needed
Updates to use nav with chrome-service for itless
No description provided.