Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Update build #2672

Merged
merged 74 commits into from
Nov 17, 2023
Merged

[stable] Update build #2672

merged 74 commits into from
Nov 17, 2023

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@app-sre-bot
Copy link

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #2672 (cef24fb) into master-stable (dce730b) will decrease coverage by 0.36%.
Report is 33 commits behind head on master-stable.
The diff coverage is 49.21%.

❗ Current head cef24fb differs from pull request most recent head 2853d38. Consider uploading reports for the commit 2853d38 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           master-stable    #2672      +/-   ##
=================================================
- Coverage          57.47%   57.12%   -0.36%     
=================================================
  Files                 93       97       +4     
  Lines               2843     2948     +105     
  Branches             582      605      +23     
=================================================
+ Hits                1634     1684      +50     
- Misses              1208     1263      +55     
  Partials               1        1              
Files Coverage Δ
src/components/AllServices/AllServicesIcons.ts 100.00% <100.00%> (ø)
src/components/AppFilter/useAppFilter.ts 94.38% <100.00%> (ø)
src/components/Search/SearchTypes.ts 100.00% <100.00%> (ø)
src/hooks/useBreadcrumbsLinks.ts 76.66% <100.00%> (ø)
src/hooks/useChromeServiceEvents.ts 44.18% <100.00%> (ø)
src/utils/common.ts 62.20% <100.00%> (ø)
src/utils/fetchNavigationFiles.ts 51.35% <100.00%> (ø)
src/jwt/jwt.ts 73.15% <50.00%> (-0.29%) ⬇️
src/auth/index.ts 31.57% <71.42%> (+1.94%) ⬆️
src/hooks/useAllServices.ts 29.20% <0.00%> (-0.53%) ⬇️
... and 4 more

Hyperkid123 and others added 27 commits November 7, 2023 11:02
Enable all services filtering by service group titles.
Add name for context switcher dropdown.
Add aditional logic for pendo guides stopping.
Move console.err after pendo retries are exhausted
Call initSuccess for cognito envs (causes cs-jwt to be set)
@florkbr
Copy link
Contributor

florkbr commented Nov 17, 2023

We need several of these fixed for our itless envs. For now this looks safe to merge. I will revert if there are any reported issues.

@florkbr florkbr merged commit b5605c6 into master-stable Nov 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants