Update patternfly quickstarts #2870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randomnetcat
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Hyperkid123
approved these changes
Jun 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2870 +/- ##
=======================================
Coverage 63.03% 63.03%
=======================================
Files 210 210
Lines 4612 4612
Branches 913 913
=======================================
Hits 2907 2907
Misses 1658 1658
Partials 47 47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
@patternfly/quickstartsto5.4.0-prerelease.1, which includes this feature, which we added to support RedHatInsights/learning-resources#54. I have tested this locally, and it does indeed resolve the issue of focus being pulled to the drawer when the quickstart changes while the panel is open.