fix(RHINENG-10654): Reimplement Sentry #2881

adonispuente · 2024-06-28T19:52:42Z

This reconfigures sentry so that it handles multiple frontends properly with chrome being the wrapper.
Currently there are a few changes I need to make in the settings of the repo itself to add secret keys to the environment, as well as a CI/CD addition, but these changes will allow the projects to be better monitored. I dont have perms for this and will ping platform team in regards to the set up aspect, those changes must be merged for this to work at all

This is step 1, but by the end, ideally, the cp-001 project will only report errors sentry deems is from chrome, and all the apps will have their own projects where we can monitor the health of specific apps.
All the apps would need to do after this is done is have a similar PR like this : https://github.com/RedHatInsights/insights-advisor-frontend/pull/1268/files
and then some CI/CD changes + secret variables added

https://issues.redhat.com/browse/RHINENG-10654

codecov-commenter · 2024-06-28T19:59:12Z

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.00%. Comparing base (67d7d4a) to head (f49af70).

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #2881       +/-   ##
===========================================
- Coverage   63.44%   48.00%   -15.44%     
===========================================
  Files         202      105       -97     
  Lines        4650     2552     -2098     
  Branches      858      468      -390     
===========================================
- Hits         2950     1225     -1725     
+ Misses       1689      917      -772     
- Partials       11      410      +399

Files	Coverage Δ
src/utils/sentry.ts	`0.00% <0.00%> (-16.22%)`	⬇️

... and 174 files with indirect coverage changes

config/webpack.config.js

config/webpack.plugins.js

Hyperkid123

Exposed federated modules are failing to be build. Here is the common error:

ERROR in ./src/components/FavoriteServices/DashboardFavorites.tsx
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: Bindings not found.
    at Compiler.<anonymous> (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:227:19)
    at Generator.next (<anonymous>)
    at /home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:27:12)
    at Compiler.transform (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:203:16)
    at Object.transform (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:352:21)
    at Object.<anonymous> (/home/martin/insights/insights-chrome/node_modules/swc-loader/src/index.js:97:21)
 @ container entry ./DashboardFavorites[0]

config/webpack.plugins.js

src/utils/sentry.ts

adonispuente · 2024-07-10T21:11:56Z

Exposed federated modules are failing to be build. Here is the common error:

ERROR in ./src/components/FavoriteServices/DashboardFavorites.tsx
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: Bindings not found.
    at Compiler.<anonymous> (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:227:19)
    at Generator.next (<anonymous>)
    at /home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:27:12)
    at Compiler.transform (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:203:16)
    at Object.transform (/home/martin/insights/insights-chrome/node_modules/@swc/core/index.js:352:21)
    at Object.<anonymous> (/home/martin/insights/insights-chrome/node_modules/swc-loader/src/index.js:97:21)
 @ container entry ./DashboardFavorites[0]

I believe the issue is the tsconfig, "sourceRoot": "/",
This is needed for sentry to map against hidden source maps. Looking into the most non-hacky solution i can come up with.

adonispuente · 2024-07-11T14:56:39Z

ci keeps failing because it cant find the container for this PR

adonispuente · 2024-07-11T15:38:55Z

/retest

adonispuente · 2024-07-11T19:47:58Z

/retest

adonispuente · 2024-07-11T20:37:50Z

converting to draft for a bit. I need to find a better way to map the source maps. there are too many with no refs

adonispuente · 2024-09-11T19:44:30Z

it fails because the package.json file is missing from the directory /opt/app-root/src/ inside the container. Has this happened before? @Hyperkid123

Hyperkid123 · 2024-09-12T08:33:57Z

@adonispuente you can ignore the Jenkins issues. The pipeline is broken nd will be fixed once we migrate to konflux.

adonispuente · 2024-09-12T18:19:12Z

/retest

BlakeHolifield · 2024-09-18T18:05:02Z

Just a heads up, this PR seems to be causing a webpack-dev-server issue and looping forever in some jenkins jobs.

12:21:01 [webpack-cli] TypeError: Cannot read properties of undefined (reading 'constructor')
12:21:01     at /home/tester/workspace/node_modules/webpack-dev-server/lib/Server.js:1860:22
12:21:01     at Array.find (<anonymous>)
12:21:01     at /home/tester/workspace/node_modules/webpack-dev-server/lib/Server.js:1859:60
12:21:01     at Array.forEach (<anonymous>)
12:21:01     at Server.initialize (/home/tester/workspace/node_modules/webpack-dev-server/lib/Server.js:1846:17)
12:21:01     at Server.start (/home/tester/workspace/node_modules/webpack-dev-server/lib/Server.js:3358:16)
12:21:01     at async Command.<anonymous> (/home/tester/workspace/node_modules/@webpack-cli/serve/lib/index.js:158:21)
12:21:01     at async Command.parseAsync (/home/tester/workspace/node_modules/commander/lib/command.js:935:5)
12:21:01     at async Command.<anonymous> (/home/tester/workspace/node_modules/webpack-cli/lib/webpack-cli.js:1356:13)
12:21:01     at async Command.parseAsync (/home/tester/workspace/node_modules/commander/lib/command.js:935:5)
12:21:03 making HTTP(S) head request to  url:https://127.0.0.1:1337/webpack-dev-server ...
12:21:03 (node:82) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS

adonispuente · 2024-09-20T18:57:50Z

/retest

adonispuente · 2024-09-25T19:50:43Z

@Hyperkid12 Everything else is passing other than synk. I dont have access to view why its failing. Can you give me perms?

Hyperkid123 · 2024-09-26T07:43:53Z

@Hyperkid12 Everything else is passing other than synk. I dont have access to view why its failing. Can you give me perms?

It's just a random thing in package.json nothing you should need to be worried about.

Hyperkid123

Something is wrong with the build process. Here is how I can reproduce issues in my machine.

run npm ci
run npm run build
run npm i
run npm run build

If I try to run build after regular dependency install, the build fails with:

assets by status 9.45 KiB [cached] 8 assets
runtime modules 9.36 KiB 14 modules
built modules 237 bytes [built]
  modules by path ./src/components/FavoriteServices/*.tsx 78 bytes
    ./src/components/FavoriteServices/LandingNavFavorites.tsx 39 bytes [built] [code generated] [1 error]
    ./src/components/FavoriteServices/DashboardFavorites.tsx 39 bytes [built] [code generated] [1 error]
  ./src/index.ts 39 bytes [built] [code generated] [1 error]
  container entry 42 bytes [built] [code generated]
  ./src/pdf/DownloadButton.tsx 39 bytes [built] [code generated] [1 error]
  ./src/layouts/SatelliteToken.tsx 39 bytes [built] [code generated] [1 error]

ERROR in ./src/components/FavoriteServices/DashboardFavorites.tsx
Module build failed (from ./node_modules/swc-loader/src/index.js):
Error: Bindings not found.
    at Compiler.<anonymous> (/Users/martin/insights/insights-chrome/node_modules/@swc/core/index.js:227:19)
    at Generator.next (<anonymous>)
    at /Users/martin/insights/insights-chrome/node_modules/@swc/core/index.js:31:71
    at new Promise (<anonymous>)
    at __awaiter (/Users/martin/insights/insights-chrome/node_modules/@swc/core/index.js:27:12)
    at Compiler.transform (/Users/martin/insights/insights-chrome/node_modules/@swc/core/index.js:203:16)
    at Object.transform (/Users/martin/insights/insights-chrome/node_modules/@swc/core/index.js:352:21)
    at Object.<anonymous> (/Users/martin/insights/insights-chrome/node_modules/swc-loader/src/index.js:97:21)
 @ container entry ./DashboardFavorites[0]

...

Until this is eliminated, I can't merge the PR.

config/webpack.config.js

config/webpack.plugins.js

adonispuente · 2024-10-01T19:06:26Z

@Hyperkid123 After investigating the issue you described, this seems to be an issue with master branch. Currently on master,

Deleteing package.lock file and then running clear && rm -rf node_modules && npm i && npm run build and then trying to run cypress test npm run test:ct, you will encounter the errors you mentioned above as well as some other issues. The swc issue seems to be unrelated to this PR.

Hyperkid123 · 2024-10-02T08:00:49Z

@adonispuente we do not have the build issues on other branches. The changes to the build must be the root cause. The cypress component tests have their own webpack configuration. I suggest trying to poking awround there.

adonispuente · 2024-10-02T15:56:36Z

@Hyperkid123 I believe we're ok now. I wasnt able to replicate the errors you mentioned after running your flow with this version of the PR.

Hyperkid123 · 2024-10-03T08:06:10Z

@adonispuente when i run npm i I still have some changes in the lock file. Can you update it?

Other than that I think we are good now. let me just do one more pass over the code.

config/webpack.config.js

config/webpack.plugins.js

adonispuente requested review from Hyperkid123, ryelo, karelhala and florkbr as code owners June 28, 2024 19:52

adonispuente force-pushed the newSentry branch from ba07d80 to f49af70 Compare June 28, 2024 19:55

adonispuente changed the title ~~New sentry~~ fix(RHINENG-10654): Reimplement Sentry Jun 28, 2024

Hyperkid123 reviewed Jul 1, 2024

View reviewed changes

config/webpack.config.js Outdated Show resolved Hide resolved

config/webpack.plugins.js Outdated Show resolved Hide resolved

adonispuente force-pushed the newSentry branch from f49af70 to 55debc3 Compare July 9, 2024 18:28

Hyperkid123 requested changes Jul 10, 2024

View reviewed changes

config/webpack.plugins.js Outdated Show resolved Hide resolved

src/utils/sentry.ts Show resolved Hide resolved

src/utils/sentry.ts Outdated Show resolved Hide resolved

adonispuente force-pushed the newSentry branch 2 times, most recently from 8664357 to e0ebc19 Compare July 10, 2024 21:05

adonispuente marked this pull request as draft July 11, 2024 20:37

adonispuente force-pushed the newSentry branch from 4da0c29 to ae816c2 Compare September 10, 2024 20:09

adonispuente marked this pull request as ready for review September 10, 2024 20:31

adonispuente force-pushed the newSentry branch from ae816c2 to 38c88f0 Compare September 11, 2024 15:48

adonispuente requested a review from Hyperkid123 September 11, 2024 19:44

Hyperkid123 requested a review from a team September 12, 2024 08:35

adonispuente force-pushed the newSentry branch from 4168a53 to 73bcacd Compare September 17, 2024 07:33

adonispuente force-pushed the newSentry branch from 73bcacd to b41e5ad Compare September 20, 2024 18:45

Hyperkid123 requested changes Sep 26, 2024

View reviewed changes

config/webpack.config.js Outdated Show resolved Hide resolved

config/webpack.plugins.js Outdated Show resolved Hide resolved

adonispuente force-pushed the newSentry branch 10 times, most recently from a78614f to 15847d2 Compare September 30, 2024 18:59

adonispuente requested a review from Hyperkid123 October 1, 2024 19:07

adonispuente force-pushed the newSentry branch from 355ea5f to 3c544b7 Compare October 2, 2024 14:48

fix(RHINENG-10654): Reimplement Sentry

882a33b

adonispuente force-pushed the newSentry branch from 3c544b7 to 882a33b Compare October 2, 2024 15:27

Hyperkid123 reviewed Oct 3, 2024

View reviewed changes

config/webpack.config.js Outdated Show resolved Hide resolved

config/webpack.plugins.js Outdated Show resolved Hide resolved

Hyperkid123 closed this Oct 3, 2024

Hyperkid123 reopened this Oct 3, 2024

adonispuente added 2 commits October 3, 2024 11:08

update package.lock and notes

9d6d4cf

PR suggestions

994cefe

adonispuente requested a review from Hyperkid123 October 3, 2024 16:42

adonispuente mentioned this pull request Oct 3, 2024

feat(sentry): Add sentry integration for inventory RedHatInsights/insights-inventory-frontend#2259

Draft

Hyperkid123 approved these changes Oct 4, 2024

View reviewed changes

Hyperkid123 merged commit 4991bb3 into RedHatInsights:master Oct 4, 2024
9 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(RHINENG-10654): Reimplement Sentry #2881

fix(RHINENG-10654): Reimplement Sentry #2881

adonispuente commented Jun 28, 2024 •

edited

Loading

codecov-commenter commented Jun 28, 2024 •

edited

Loading

Hyperkid123 left a comment

adonispuente commented Jul 10, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Sep 11, 2024

Hyperkid123 commented Sep 12, 2024

adonispuente commented Sep 12, 2024

BlakeHolifield commented Sep 18, 2024

adonispuente commented Sep 20, 2024

adonispuente commented Sep 25, 2024

Hyperkid123 commented Sep 26, 2024

Hyperkid123 left a comment

adonispuente commented Oct 1, 2024

Hyperkid123 commented Oct 2, 2024

adonispuente commented Oct 2, 2024

Hyperkid123 commented Oct 3, 2024

fix(RHINENG-10654): Reimplement Sentry #2881

fix(RHINENG-10654): Reimplement Sentry #2881

Conversation

adonispuente commented Jun 28, 2024 • edited Loading

codecov-commenter commented Jun 28, 2024 • edited Loading

Codecov Report

Hyperkid123 left a comment

Choose a reason for hiding this comment

adonispuente commented Jul 10, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Jul 11, 2024

adonispuente commented Sep 11, 2024

Hyperkid123 commented Sep 12, 2024

adonispuente commented Sep 12, 2024

BlakeHolifield commented Sep 18, 2024

adonispuente commented Sep 20, 2024

adonispuente commented Sep 25, 2024

Hyperkid123 commented Sep 26, 2024

Hyperkid123 left a comment

Choose a reason for hiding this comment

adonispuente commented Oct 1, 2024

Hyperkid123 commented Oct 2, 2024

adonispuente commented Oct 2, 2024

Hyperkid123 commented Oct 3, 2024

adonispuente commented Jun 28, 2024 •

edited

Loading

codecov-commenter commented Jun 28, 2024 •

edited

Loading