Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusts stack chart color, tooltip position #144

Merged
merged 1 commit into from
May 5, 2020
Merged

Adjusts stack chart color, tooltip position #144

merged 1 commit into from
May 5, 2020

Conversation

AllenBW
Copy link
Contributor

@AllenBW AllenBW commented May 4, 2020 •
edited
Loading

addresses #137 (comment)

addresses #137 (comment)

looks like

Screen Shot 2020-05-04 at 12 55 13 PM

Screen Shot 2020-05-04 at 12 55 01 PM

@AllenBW AllenBW self-assigned this May 4, 2020
@AllenBW AllenBW added enhancement New feature or request needs design approval labels May 4, 2020
kybaker
kybaker approved these changes May 4, 2020
View reviewed changes
Copy link

@kybaker kybaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@christiemolloy
Copy link
Contributor

Your changes look good, I wonder why the advisor/vulnerability cards are growing outside of their parent width

Screen Shot 2020-05-04 at 3 38 59 PM

@AllenBW
Copy link
Contributor Author

AllenBW commented May 4, 2020

the only way to get the tooltip on the top is to kill constrainToVisibleArea as the chart doesn’t take up ah bunch of vertical space outside of the bar, the only place tooltips can go with constrainToVisibleArea enabled is on the chart

@AllenBW AllenBW merged commit 687227c into master May 5, 2020
@AllenBW AllenBW deleted the enhancement/stack-chart-fixes branch May 5, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kybaker kybaker kybaker approved these changes

@christiemolloy christiemolloy Awaiting requested review from christiemolloy

@ryelo ryelo Awaiting requested review from ryelo

Assignees

@AllenBW AllenBW

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AllenBW @christiemolloy @kybaker