update cypress test

RedHatInsights · Jun 7, 2024 · e2279ec · e2279ec
1 parent 8c9e231
commit e2279ec
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/src/components/GroupSystems/GroupSystems.cy.js b/src/components/GroupSystems/GroupSystems.cy.js
@@ -26,6 +26,7 @@ import {
   PAGINATION_NEXT,
   PT_CONDITIONAL_FILTER_TOGGLE,
   PT_BULK_SELECT,
+  PT_BULK_SELECT_CHECKBOX,
 } from '@redhat-cloud-services/frontend-components-utilities';
 import _, { cloneDeep } from 'lodash';
 import fixtures from '../../../cypress/fixtures/hosts.json';
@@ -309,7 +310,7 @@ describe('selection and bulk selection', () => {
   });
 
   it('can select and deselect systems', () => {
-    const middleRow = Math.ceil(DEFAULT_ROW_COUNT / 4);
+    const middleRow = Math.ceil(DEFAULT_ROW_COUNT / 7.5);
     selectRowN(middleRow);
     checkSelectedNumber(1);
     selectRowN(Math.ceil(middleRow / 2));
@@ -346,7 +347,7 @@ describe('selection and bulk selection', () => {
 
   it('can select none', () => {
     selectRowN(1);
-    cy.get(PT_BULK_SELECT).click(); // open selection dropdown
+    cy.get(PT_BULK_SELECT_CHECKBOX).click(); // open selection dropdown
     cy.get(DROPDOWN_ITEM).contains('Select none (0 items)').click();
     checkSelectedNumber(0);
   });

diff --git a/src/components/GroupsTable/GroupsTable.cy.js b/src/components/GroupsTable/GroupsTable.cy.js
@@ -295,7 +295,7 @@ describe('selection and bulk selection', () => {
 
   it('can select none', () => {
     selectRowN(1);
-    cy.get(PT_BULK_SELECT).contains('1 selected').click(); // open selection dropdown
+    cy.get(PT_BULK_SELECT).contains('1 selected').click().click();
     cy.get(PT_BULK_SELECT_LIST).find(MENU_ITEM).eq(1).click();
     checkSelectedNumber(0);
   });

diff --git a/src/routes/InventoryDetail.cy.js b/src/routes/InventoryDetail.cy.js
@@ -46,7 +46,7 @@ hostInGroup.results[0].system_profile.operating_system.name = 'RHEL';
 
 describe('renders correctly', () => {
   before(() => cy.mockWindowInsights());
-  beforeEach(() => prepareTest());
+  beforeEach(() => prepareTest(hostInGroup));
 
   it('renders main components for edge host', () => {
     cy.get('.ins-entity-detail').should('have.length', 1);
@@ -133,7 +133,8 @@ describe('rbac integration', () => {
                 attributeFilter: {
                   key: 'group.id',
                   operation: 'equal',
-                  value: null,
+                  //ask about this value
+                  value: 'group-a-id',
                 },
               },
             ],
@@ -142,7 +143,7 @@ describe('rbac integration', () => {
       })
     );
 
-    beforeEach(prepareTest);
+    beforeEach(() => prepareTest(hostInGroup));
 
     it('should enable delete and edit buttons', () => {
       cy.contains('Delete').should('exist').and('be.enabled');