Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM-2135: add baseline_id and osversion into /package/systems #1257

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Jul 4, 2023

Referenced Jiras:
https://issues.redhat.com/browse/SPM-2135

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (c6dca18) 61.34% compared to head (7081451) 61.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1257      +/-   ##
==========================================
- Coverage   61.34%   61.29%   -0.05%     
==========================================
  Files         106      106              
  Lines        6540     6542       +2     
==========================================
- Hits         4012     4010       -2     
- Misses       2008     2011       +3     
- Partials      520      521       +1     
Flag Coverage Δ
unittests 61.29% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
listener/upload.go 77.94% <0.00%> (-0.47%) ⬇️
manager/controllers/package_systems.go 62.22% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

manager/controllers/package_systems.go Outdated Show resolved Hide resolved
@MichaelMraka MichaelMraka merged commit b1b2f59 into RedHatInsights:master Jul 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants