Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESSNTL-4817: rewrite filter parsing #1271

Merged
merged 13 commits into from
Jul 28, 2023

Conversation

MichaelMraka
Copy link
Collaborator

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Jul 24, 2023

@psegedy psegedy self-requested a review July 24, 2023 17:06
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 94.50% and project coverage change: -0.63% ⚠️

Comparison is base (e0b99e8) 61.11% compared to head (f80b87b) 60.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
- Coverage   61.11%   60.48%   -0.63%     
==========================================
  Files         106      106              
  Lines        6687     6631      -56     
==========================================
- Hits         4087     4011      -76     
- Misses       2061     2086      +25     
+ Partials      539      534       -5     
Flag Coverage Δ
unittests 60.48% <94.50%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
manager/controllers/baseline_systems_export.go 55.00% <ø> (ø)
manager/controllers/system_packages.go 53.73% <50.00%> (-0.96%) ⬇️
manager/controllers/baseline_systems.go 48.59% <66.66%> (-0.45%) ⬇️
manager/controllers/utils.go 79.72% <97.50%> (+2.03%) ⬆️
base/database/utils.go 7.69% <100.00%> (+1.60%) ⬆️
manager/controllers/advisories.go 67.79% <100.00%> (ø)
manager/controllers/advisories_export.go 48.97% <100.00%> (-4.09%) ⬇️
manager/controllers/advisory_systems.go 42.85% <100.00%> (ø)
manager/controllers/advisory_systems_export.go 41.86% <100.00%> (ø)
manager/controllers/baselines.go 83.78% <100.00%> (ø)
... and 10 more

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy
Copy link
Member

psegedy commented Jul 25, 2023

some tests seem to be broken, 1 test seems to be failing due to changed openapi scheme, others might be affected by potential bug in #1264

@psegedy
Copy link
Member

psegedy commented Jul 25, 2023

/retest

@MichaelMraka
Copy link
Collaborator Author

/retest

@MichaelMraka MichaelMraka merged commit 34d3ec7 into RedHatInsights:master Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants