Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM-2119: remove package parsing where not needed #1273

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Jul 25, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Jul 25, 2023

Referenced Jiras:
https://issues.redhat.com/browse/SPM-2119

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.06% 🎉

Comparison is base (2874520) 60.68% compared to head (c2a6cfe) 60.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
+ Coverage   60.68%   60.74%   +0.06%     
==========================================
  Files         106      106              
  Lines        6735     6741       +6     
==========================================
+ Hits         4087     4095       +8     
+ Misses       2109     2108       -1     
+ Partials      539      538       -1     
Flag Coverage Δ
unittests 60.74% <83.33%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
base/utils/rpm.go 52.00% <0.00%> (-3.32%) ⬇️
evaluator/evaluate_advisories.go 69.37% <ø> (ø)
evaluator/remediations.go 80.00% <ø> (ø)
manager/controllers/system_detail.go 31.18% <ø> (ø)
listener/upload.go 77.94% <66.66%> (ø)
evaluator/evaluate.go 68.78% <86.95%> (+0.37%) ⬆️
base/utils/vmaas.go 72.00% <100.00%> (ø)
evaluator/evaluate_baseline.go 92.59% <100.00%> (ø)
evaluator/evaluate_packages.go 79.16% <100.00%> (+1.23%) ⬆️
evaluator/package_cache.go 83.73% <100.00%> (+1.86%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit 923028c into RedHatInsights:master Jul 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants