RHINENG-1197: fix meta links #1277
Conversation
|
Referenced Jiras: |
so we can put them back into links in meta section
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
==========================================
- Coverage 60.54% 60.47% -0.08%
==========================================
Files 106 106
Lines 6631 6646 +15
==========================================
+ Hits 4015 4019 +4
- Misses 2085 2096 +11
Partials 531 531
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
/retest |
1 similar comment
|
/retest |
| var validSystemProfileFilters = map[string]bool{ | ||
| "sap_sids": true, | ||
| "sap_system": true, | ||
| "mssql": true, | ||
| "mssql->version": true, | ||
| "ansible": true, | ||
| "ansible->controller_version": true, | ||
| } | ||
|
|
There was a problem hiding this comment.
don't we need this map to allow only certain keywords for filter? We should be able to return 400 if user tries something like filter[system_profile][asdf]=asdf but I don't know if we can do it with the old code or not
There was a problem hiding this comment.
There was a problem hiding this comment.
we should make sure we don't break any checks for invalid filters if we have them now, I'd rely on unit tests and QE to provide an answer whether the functionality is correct or not
if it doesn't break any current checks for invalid filters, then LGTM
PR checks are broken until Brandon and app-sre make necessary changes
|
/retest |
|
There's couple of invalid filter tests, e.g. |
Secure Coding Practices Checklist GitHub Link
Secure Coding Checklist