Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESSNTL-4817: fix rbac with multiple inventory and patch permissions #1291

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Aug 14, 2023

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Aug 14, 2023

Commits missing Jira IDs:
5cf54f3

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 93.75% and project coverage change: +0.13% 🎉

Comparison is base (9d761af) 61.70% compared to head (5cf54f3) 61.83%.
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1291      +/-   ##
==========================================
+ Coverage   61.70%   61.83%   +0.13%     
==========================================
  Files         106      106              
  Lines        6651     6674      +23     
==========================================
+ Hits         4104     4127      +23     
  Misses       2013     2013              
  Partials      534      534              
Flag Coverage Δ
unittests 61.83% <93.75%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
listener/upload.go 78.30% <85.71%> (+0.36%) ⬆️
manager/middlewares/rbac.go 80.26% <100.00%> (+2.32%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy merged commit 7aa09fe into RedHatInsights:master Aug 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants