chore: unify linting and formatting configs #1420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katarinazaprazna
force-pushed
the
unify-linting-and-formatting-configs
branch
from
87187a6 to
dfdd7b9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1420 +/- ##
==========================================
- Coverage 62.93% 62.36% -0.57%
==========================================
Files 128 128
Lines 3399 3329 -70
Branches 906 901 -5
==========================================
- Hits 2139 2076 -63
+ Misses 1141 1132 -9
- Partials 119 121 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
katarinazaprazna
force-pushed
the
unify-linting-and-formatting-configs
branch
2 times, most recently
from
04874c3 to
ae2c4cf
Compare
Unifying configs across the Patch and content-sources-frontend repositories. Patch now uses Prettier for formatting and ESLint for quality rules only. ESLint has also been upgraded to v9.
Adjust the commitlint config to use the 50/72 rule similarly to the content-sources-frontend repository
This commit enforces the `import/no-duplicates` rule in ESLint with auto-fix enabled.
katarinazaprazna
force-pushed
the
unify-linting-and-formatting-configs
branch
from
ae2c4cf to
575daa5
Compare
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configuration Alignment
/* global ... */comments by moving environment settings into the main ESLint fileTool Modernization and Scope
/srcdirectory, excluding the/configfolder to prevent issues with older conventionsGit
commitlintconfig to enforce the 50/72 rule for commit message formatting, aligning with the content-sources-frontend repositoryHow to test the PR
npm run lint:js:fix,npm run lint:sassandnpm run prettier:checkwill be a message confirming that all linting and formatting rules have been satisfied.Checklist: