Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload compressed sqlite dump to s3 #1166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

psegedy
Copy link
Member

@psegedy psegedy commented Oct 15, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Oct 15, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13599

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 28.30189% with 38 lines in your changes missing coverage. Please review.

Project coverage is 68.23%. Comparing base (5a56460) to head (e0eda73).
Report is 97 commits behind head on master.

Files with missing lines Patch % Lines
vmaas/reposcan/exporter.py 36.36% 14 Missing ⚠️
vmaas/reposcan/reposcan.py 33.33% 14 Missing ⚠️
vmaas/common/config.py 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1166      +/-   ##
==========================================
+ Coverage   62.98%   68.23%   +5.25%     
==========================================
  Files          70       73       +3     
  Lines        6800     6076     -724     
==========================================
- Hits         4283     4146     -137     
+ Misses       2517     1927     -590     
- Partials        0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy psegedy changed the title WIP: dump to s3 feat: upload compressed sqlite dump to s3 Oct 16, 2024
@psegedy psegedy requested a review from jdobes October 16, 2024 16:17
@psegedy psegedy marked this pull request as ready for review October 16, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants