Skip to content

Commit

Permalink
Remove uses of autogenerated ouia ids
Browse files Browse the repository at this point in the history
  • Loading branch information
leSamo committed May 31, 2024
1 parent e15b45f commit 9586aed
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions src/Components/PresentationalComponents/Kebab/KebabItems.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ export const kebabItemDownloadPDF = (loading, downloadReport, props = {}) => (
);

export const kebabItemEditBusinessRisk = (showBusinessRiskModal, cves, props = {}) => (
<DropdownItem key="editBusinessRisk" onClick={() => showBusinessRiskModal(cves)} {...props}>
<DropdownItem key="editBusinessRisk" ouiaId="edit-business-risk" onClick={() => showBusinessRiskModal(cves)} {...props}>
<FormattedMessage {...messages.kebabEditBusinessRisk} />
</DropdownItem>
);

export const kebabItemEditStatus = (showStatusModal, cves, inventoryIds, props = {}) => (
<DropdownItem key="editStatus" onClick={() => showStatusModal(cves, inventoryIds)} {...props}>
<DropdownItem key="editStatus" ouiaId="edit-status" onClick={() => showStatusModal(cves, inventoryIds)} {...props}>
<FormattedMessage {...messages.kebabEditStatus} />
</DropdownItem>
);
8 changes: 4 additions & 4 deletions src/Components/SmartComponents/CVEs/CVEs.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,17 @@ describe('CVE list table', () => {
it('shows buttons to edit status or business risk', () => {
cy.get('.ins-c-primary-toolbar__actions > .pf-v5-c-menu-toggle').click();

cy.get('[data-ouia-component-id="OUIA-Generated-DropdownItem-1"] > .pf-v5-c-menu__item')
cy.get('[data-ouia-component-id="edit-business-risk"] > .pf-v5-c-menu__item')
.contains('Edit business risk')
.should('exist');

cy.get('[data-ouia-component-id="OUIA-Generated-DropdownItem-2"] > .pf-v5-c-menu__item')
cy.get('[data-ouia-component-id="edit-status"] > .pf-v5-c-menu__item')
.contains('Edit status')
.should('exist');
});

it.skip('shows row actions', () => {
cy.get('[data-ouia-component-id="OUIA-Generated-TableRow-613"] > .pf-v5-c-table__action > .pf-v5-c-menu-toggle')
it('shows row actions', () => {
cy.get('.pf-v5-c-table__action > .pf-v5-c-menu-toggle')
.should('exist');
});

Expand Down
4 changes: 2 additions & 2 deletions src/Components/SmartComponents/CVEs/CVEsTableToolbar.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const CVEsTableToolbarWithContext = ({ context, canEditStatusOrBusinessRisk, can
business_risk_id: attributes ? attributes.business_risk_id : business_risk_id,
justification: attributes ? attributes.business_risk_text : business_risk_text
})), true),
props: { isDisabled: !selectedCvesCount }
props: { isDisabled: !selectedCvesCount, ouiaId: 'edit-business-risk' }
},
{
label: intl.formatMessage(messages.editStatus),
Expand All @@ -112,7 +112,7 @@ const CVEsTableToolbarWithContext = ({ context, canEditStatusOrBusinessRisk, can
justification: attributes ? attributes.status_text : status_justification,
status_id: attributes ? attributes.status_id : status_id
}), []), true),
props: { isDisabled: !selectedCvesCount }
props: { isDisabled: !selectedCvesCount, ouiaId: 'edit-status' }
}
] : [],
{
Expand Down

0 comments on commit 9586aed

Please sign in to comment.