Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVEs without errata feature #1908

Merged
merged 9 commits into from
Aug 4, 2023

Conversation

leSamo
Copy link
Member

@leSamo leSamo commented Jun 13, 2023

Part of VULN-2673 and VULN-2677.

Mockups for CVE detail page (System detail page is analogous): https://www.sketch.com/s/4d721f7e-f57e-46e6-ba1c-739c0cad040e/a/g0Mbwqx

@leSamo leSamo requested a review from a team as a code owner June 13, 2023 14:40
@jira-linking
Copy link

jira-linking bot commented Jun 13, 2023

Commits missing Jira IDs:
a5f796f
4de355e
711ce4a
e64ca16
af7e42a
f2c04d8
d72d2f2
7b65b4f
2bb5d10

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Patch coverage: 51.92% and project coverage change: -0.40% ⚠️

Comparison is base (752d7d3) 70.52% compared to head (14ff7ac) 70.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1908      +/-   ##
==========================================
- Coverage   70.52%   70.12%   -0.40%     
==========================================
  Files         119      120       +1     
  Lines        3043     3083      +40     
  Branches      901      919      +18     
==========================================
+ Hits         2146     2162      +16     
- Misses        897      921      +24     
Files Changed Coverage Δ
...nts/SmartComponents/Reports/Common/firstPagePDF.js 86.76% <ø> (ø)
...onents/SmartComponents/Reports/Common/tablePage.js 100.00% <ø> (ø)
...ents/SmartComponents/Reports/DownloadCVEsReport.js 4.68% <0.00%> (-0.16%) ⬇️
...omponents/SmartComponents/SystemCves/SystemCves.js 84.09% <ø> (ø)
src/Helpers/APIHelper.js 27.95% <0.00%> (-0.62%) ⬇️
src/Helpers/Hooks.js 39.08% <ø> (ø)
src/Helpers/ReportsHelper.js 73.84% <0.00%> (-4.85%) ⬇️
...rimaryToolbarFilters/AdvisoryAvailabilityFilter.js 11.11% <11.11%> (ø)
src/Components/SmartComponents/CVEs/CVEsTable.js 96.87% <50.00%> (-3.13%) ⬇️
src/Helpers/VulnerabilityHelper.js 97.50% <50.00%> (-2.50%) ⬇️
... and 7 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gkarat
Copy link
Contributor

gkarat commented Jun 20, 2023

Please put some notes on how to test this/brief description and jira ticket

@gkarat gkarat removed the request for review from a team June 20, 2023 09:22
@leSamo leSamo marked this pull request as draft June 26, 2023 12:23
@leSamo leSamo marked this pull request as ready for review June 30, 2023 13:09
@leSamo leSamo force-pushed the advisory-avail-filter branch 2 times, most recently from 9db31d2 to de6ffbc Compare July 3, 2023 14:08
@leSamo leSamo changed the title Add advisory availability filter to both detail pages CVEs without errata feature Jul 25, 2023
@leSamo leSamo requested a review from a team July 29, 2023 22:26
@leSamo
Copy link
Member Author

leSamo commented Jul 31, 2023

/retest

@leSamo leSamo force-pushed the advisory-avail-filter branch 2 times, most recently from 3c76329 to 2e3694c Compare July 31, 2023 23:00
Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you @leSamo!

@leSamo
Copy link
Member Author

leSamo commented Aug 4, 2023

/retest

@leSamo leSamo merged commit 25e6d9c into RedHatInsights:master Aug 4, 2023
3 checks passed
LiorKGOW pushed a commit to LiorKGOW/vulnerability-ui that referenced this pull request Jan 8, 2024
(no jira)

This removes the old eslint configuration and replaces it with the one from https://github.com/RedHatInsights/frontend-starter-app so that Inventory is aligned with other apps in terms of linting and also using the latest custom rules provided by platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants