feat(ESSNTL-3717): Add Inventory groups filter and column #1920
Conversation
There was a problem hiding this comment.
The column manager does nothing if I deselect the Group column and submit. The columns stay the same, however, the Group column must disappear I believe...
Screencast.from.2023-07-25.11-19-45.webm
Besides that, just a couple of nit-picks. Once we have some changes on the back-end side, we would need another PR to: 1) make sure the active groups filter adds the appropriate parameter to requests to /api/v1/vulnerability/systems, 2) we read the data about each host's group from the correct key path (to be confirmed with the Vulnerability team how they are gonna propagate this value).
gkarat
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1920 +/- ##
==========================================
- Coverage 71.67% 71.58% -0.09%
==========================================
Files 116 117 +1
Lines 2930 2939 +9
Branches 878 882 +4
==========================================
+ Hits 2100 2104 +4
- Misses 830 835 +5
☔ View full report in Codecov by Sentry. |
https://issues.redhat.com/browse/ESSNTL-3717
How to test - check that the groups filter is present as well as groups filter, check that the groups column is present in the column manager.
Try to turn on/off the feature flag and check that the table hides all info about groups.
The sorting by group is not implemented
Data about groups is not available until it implemented so group links are not present in the column
Groups feature flag ON
Groups feature flag OFF
